fix(e2e): use exact locator for Open menu button in design review screenshots#1106
Merged
Conversation
…eenshots The regex /menu/i matched both "Open menu" and "Close menu" buttons, causing Playwright strict mode violations on tablet/mobile viewports. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
steilerDev
force-pushed
the
fix/design-review-sidebar-locator
branch
from
fedfce9 to
eb86403
Compare
Contributor
|
🎉 This PR is included in version 2.2.0-beta.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getByRole('button', { name: /menu/i })matched both "Open menu" and "Close menu" buttons on tablet/mobile viewports'Open menu'name matchTest plan
🤖 Generated with Claude Code