fix(datatable): fix filter click propagation, clear filters, and column settings positioning#1123
Merged
Merged
Conversation
…mn settings positioning Bug 1: Add stopPropagation on filter popover container to prevent clicks inside filter overlays from triggering column sort. Bug 2: Delete all known filter URL params before setting new ones in handleStateChange on server-side pages (WorkItems, HouseholdItems, Invoices) so clear filters properly removes stale params. Bug 3: Move column settings popover position calculation from useEffect into onClick handler so position is computed synchronously before render, preventing mispositioned flash. Fixes #1122 Co-Authored-By: Claude frontend-developer (Haiku 4.5) <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 2.2.0-beta.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Mar 25, 2026
Contributor
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1122
Test plan
Co-Authored-By: Claude frontend-developer (Haiku 4.5) noreply@anthropic.com
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com