fix(datatable): auto-apply filters, fix enum labels, always-visible header, filtered empty state#1129
Merged
Merged
Conversation
…eader, filtered empty state
- Enum filter: wrap checkbox+label in <label> so clicking text toggles
- All filters: remove Apply button, call onChange immediately on interaction
- Table header always renders even with 0 items
- Differentiate filtered-empty ("No items match") vs truly-empty states
Fixes #1128
Co-Authored-By: Claude frontend-developer (Haiku 4.5) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove Apply/Clear button assertions (buttons removed in auto-apply change). Add tests verifying onChange called immediately on filter interaction. Fix empty state test to expect table header always present. Co-Authored-By: Claude qa-integration-tester (Sonnet 4.6) <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 2.2.0-beta.12 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
steilerDev
pushed a commit
that referenced
this pull request
Mar 22, 2026
…gates to onApply Root cause: PR #1129 made filters call onChange immediately, but DataTableFilterPopover passed setLocalValue as onChange, so values got stuck in local state and never reached onApply → onFilter. Fix: Remove localValue intermediary — pass onApply directly as onChange to filter components. Add outside-click + Escape close handler to DataTableHeader (popover no longer closes on every filter change, allowing multi-select in enum filters). Add auto-apply test coverage in DataTableFilterPopover.test.tsx. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
steilerDev
added a commit
that referenced
this pull request
Mar 22, 2026
…gates to onApply (#1134) Root cause: PR #1129 made filters call onChange immediately, but DataTableFilterPopover passed setLocalValue as onChange, so values got stuck in local state and never reached onApply → onFilter. Fix: Remove localValue intermediary — pass onApply directly as onChange to filter components. Add outside-click + Escape close handler to DataTableHeader (popover no longer closes on every filter change, allowing multi-select in enum filters). Add auto-apply test coverage in DataTableFilterPopover.test.tsx. Co-authored-by: Claude product-architect (Opus 4.6) <noreply@anthropic.com>
This was referenced Mar 25, 2026
Contributor
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<label>wrapping)Fixes #1128
Test plan
Co-Authored-By: Claude frontend-developer (Haiku 4.5) noreply@anthropic.com
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com