fix(e2e): update ScheduleSubNav aria-label locator#1190
Merged
Conversation
The E2E test was looking for navigation with name 'Gantt' but the ScheduleSubNav component uses the i18n key 'schedule.navigation.ariaLabel' which resolves to 'Schedule section navigation' in English. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The test navigated to the same URL that setLanguage already redirected to (/project/overview), so the second goto + reload was unreliable — the browser could skip the full page load, leaving i18next initialized with English. Replace with a single goto and an explicit wait for the German page heading to confirm the locale switch took effect, matching the pattern used by the other working German locale tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… mobile - Increase waitForResponse and waitForURL timeouts from 10s to 15s in WorkItemsPage.search() and VendorsPage.search()/clearSearch(). On mobile viewports, fill() can take up to 10s (actionTimeout) leaving no headroom for debounce + API round-trip within the old 10s limit. - Add waitForVendorsLoaded() after search/clearSearch in VendorsPage to ensure React has committed filtered results before callers read the DOM via getVendorNames(), preventing .all() race conditions on mobile where the API response arrives before the re-render completes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ize test - Remove goto+reload pattern from i18n-categories German locale tests (trades, budget categories, household item categories). Instead use a single goto with waitUntil:'commit' and wait for the expected German text as the locale-readiness indicator. The reload was unreliable because navigating to the same URL the SPA already loaded could skip the full page load. - Add defensive hiddenCards preference reset before navigation in the dashboard "Customize button appears" test to prevent state pollution from parallel workers sharing the same user preferences. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 2.2.0-beta.32 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Mar 25, 2026
Contributor
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timeline-responsive.spec.tsto use the correct aria-label'Schedule section navigation'instead of'Gantt'for theScheduleSubNavnavigation elementScheduleSubNavcomponent usest('schedule.navigation.ariaLabel')which resolves to'Schedule section navigation'in English — the E2E test was using the old labelTest plan
timeline-responsive.spec.ts:472passes on all viewports (desktop, tablet, mobile)🤖 Generated with Claude Code