build(docker): remove --build-from-source, add npm cache mount#134
Merged
Conversation
Drop the unnecessary --build-from-source flag from npm ci — better-sqlite3 already auto-detects musl libc via prebuild-install and falls back to node-gyp rebuild when no matching prebuild exists. Add a BuildKit cache mount for /root/.npm so subsequent builds skip re-downloading npm packages. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 1.8.0-beta.25 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--build-from-sourceflag fromnpm ci—better-sqlite3auto-detects musl libc viaprebuild-installand falls back tonode-gyp rebuildwhen no matching prebuild exists--mount=type=cache,target=/root/.npm) so subsequent builds skip re-downloading npm packagesTest plan
docker build -t cornerstone .succeeds locallydocker run --rm cornerstone node -e "require('better-sqlite3')"loads the native addon🤖 Generated with Claude Code