chore: EPIC-02 refinement — address non-blocking review comments#50
Merged
Conversation
Contributor
|
🎉 This PR is included in version 1.6.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses non-blocking observations collected from all EPIC-02 PR reviews (#45, #47, #48, #49) as part of the epic refinement phase.
Code fixes
Fix trailing space in Sidebar className (PR feat(client): responsive layout and cross-browser compatibility #48, architect observation): The template literal
${styles.sidebar} ${isOpen ? styles.open : ''}produced a trailing space whenisOpenwas false. Switched to[styles.sidebar, isOpen && styles.open].filter(Boolean).join(' ').Wrap
splitChunksinisProductionconditional (PR feat: performance baseline with code splitting, compression & cache headers #49, architect observation):splitChunks: { chunks: 'all' }was previously applied in both dev and production modes. While harmless, it's cleaner to only apply it in production alongside the other optimization settings.Process observations (documented, no code changes)
request()not exported for potential future PATCH support (PO observation, PR feat(client): API client module (Story #31) #47)Test plan
npm run lint— 0 errorsnpm run format:check— all cleannpm run typecheck— all packages cleannpm test— 163 tests pass (18 suites)npm run build— succeedsnpm audit— 0 vulnerabilities🤖 Generated with Claude Code