chore: pre-EPIC-03 consistency cleanup#95
Merged
Conversation
CLAUDE.md states developer agents do not write tests -- the qa-integration-tester owns unit/integration tests and the e2e-test-engineer owns E2E tests. The backend-developer and frontend-developer agent definition files contradicted this by including test-writing responsibilities, workflow steps, and examples. Changes to agent definition files: - backend-developer.md: Remove test-writing from responsibilities, workflow steps 5/7, quality checks, strict boundaries, and YAML description examples - frontend-developer.md: Remove test-writing from responsibilities, workflow step 7, boundaries, and YAML description examples - Both: Add explicit "you do not write tests" guidance with instruction to run existing tests for verification - Fix stale reference to docs/api-contract.md (now GitHub Wiki) - Fix stale CSS styling list in frontend memory guidance Also updated GitHub Wiki ADRs (pushed separately): - ADR-004: Vite 6 -> Webpack 5.x - ADR-005: Vitest -> Jest 30.x + ts-jest - ADR-006: Tailwind CSS v4 -> CSS Modules Co-Authored-By: Claude product-architect (Opus 4.6) <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 1.7.0-beta.20 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 1.8.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
17 tasks
Contributor
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pre-epic consistency cleanup per CLAUDE.md convention, verifying repository alignment before starting EPIC-03.
Issues Found & Fixed
1. Agent definition files contradict CLAUDE.md test ownership rules
CLAUDE.md states: "Developer agents do not write tests" and "the
qa-integration-testeragent owns unit tests and integration tests; thee2e-test-engineeragent owns Playwright E2E browser tests."Both
backend-developer.mdandfrontend-developer.mdcontained test-writing responsibilities in their:Fix: Updated both files to:
npm test)2. GitHub Wiki ADRs referenced old tech stack (pushed to wiki repo)
Each ADR was rewritten to document the actual decision, the native binary constraint that motivated the change, and the correct consequences.
3. Minor fixes
frontend-developer.md: Stale reference todocs/api-contract.mdupdated to GitHub Wikifrontend-developer.md: Generic CSS styling list in memory guidance updated to "CSS Modules"Files Changed
.claude/agents/backend-developer.md.claude/agents/frontend-developer.mdTest Plan
npm run lint-- passesnpm run format:check-- passesnpm run typecheck-- passesnpm test-- 614 tests passnpm run build-- succeedsnpm audit-- 0 vulnerabilities🤖 Generated with Claude Code