Fix Claude Fable 5 cost totals - #1372
Conversation
|
Codex review: needs changes before merge. Reviewed June 10, 2026, 2:22 AM ET / 06:22 UTC. Summary Reproducibility: yes. from source inspection: Vertex-style Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Land the pricing/cache fix after adding bundled fallback support and regression coverage for Claude Do we have a high-confidence way to reproduce the issue? Yes, from source inspection: Vertex-style Is this the best way to solve the issue? No. The overall pricing/cache direction is maintainable, but the patch should cover the existing Vertex alias surface before merge. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 6f6cb097dc58. Label changesLabel changes:
Label justifications:
Evidence reviewedAcceptance criteria:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4413eb4133
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| private static let claude: [String: ClaudePricing] = [ | ||
| "claude-fable-5": ClaudePricing( |
There was a problem hiding this comment.
Price Vertex-formatted Fable aliases in the fallback
When Fable is logged in Vertex AI format (for example claude-fable-5@20260609 or @default), this new bundled fallback still won't be used. The models.dev lookup can normalize @ aliases, but with a stale/missing models.dev cache the code falls back to normalizeClaudeModel, which only strips -YYYYMMDD dates and leaves the @... suffix, so the dictionary lookup misses and the scanner records a zero/unpriced cost. The repo already treats @ as Claude Vertex format in CostUsageScanner+Claude, so this fallback should cover those aliases too.
Useful? React with 👍 / 👎.
4413eb4 to
91364f2
Compare
Summary
claude-fable-5Pricing
Anthropic pricing reference:
https://platform.claude.com/docs/en/about-claude/pricing
Pi session JSONL does not record Anthropic cache retention, so Pi usage keeps its persisted default cache-write tariff rather than guessing historical retention.
Proof
make checkorigin/main: clean, no accepted/actionable findingsFixes #1368