Fix Antigravity quota summary lanes - #1726
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3692151c92
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return [windows.primary, windows.secondary] | ||
| .compactMap(\.self) | ||
| .max(by: { $0.usedPercent < $1.usedPercent }) | ||
| return Self.mostConstrainedAntigravityQuotaSummaryWindow(snapshot: snapshot) |
There was a problem hiding this comment.
When menuBarShowsHighestUsage is enabled for the merged icon and a Claude/GPT quota-summary lane is the most constrained (for example Claude/GPT at 95% while Gemini is much lower), this selects Antigravity based on that non-Gemini lane. The render path in StatusItemController+Animation.applyIcon only receives the provider and then calls IconRemainingResolver.resolvedPercents, whose Antigravity compact-icon path still restricts quota-summary lanes to Gemini when any Gemini bucket is present, so the menu bar can show low Gemini bars instead of the 95% lane that caused the provider selection.
Useful? React with 👍 / 👎.
|
Codex review: needs maintainer review before merge. Reviewed June 23, 2026, 12:40 PM ET / 16:40 UTC. Summary Reproducibility: yes. Source inspection shows current main still restricts Antigravity compact quota-summary rendering to Gemini buckets while highest-usage ranking consumes that rendered resolver, and the PR tests cover Claude/GPT-constrained lanes. Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Next step before merge
Security Review detailsBest possible solution: Land a focused Antigravity fix that keeps parsed menu labels, compact icon lanes, and merged highest-usage ranking on the same rendered 5-hour and weekly quota windows. Do we have a high-confidence way to reproduce the issue? Yes. Source inspection shows current main still restricts Antigravity compact quota-summary rendering to Gemini buckets while highest-usage ranking consumes that rendered resolver, and the PR tests cover Claude/GPT-constrained lanes. Is this the best way to solve the issue? Yes. The PR’s narrowest maintainable path is to make the Antigravity icon resolver and highest-usage selector share the same rendered quota-summary lanes while keeping label normalization in the Antigravity parser. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 929d55aaf1d7. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
clawsweeper
Bot
added
proof: sufficient
2 participants
Summary
Gemini 5-hour,Claude/GPT weekly, etc.)Verification
swift test --filter 'CodexbarTests|AntigravityQuotaSummaryTests|MenuBarMetricWindowResolverTests|UsageStoreHighestUsageTests'swift test --skip-build --filter antigravitymake checkScreenshot Evidence
Gemini 5-hour,Gemini weekly,Claude/GPT 5-hour, andClaude/GPT weeklywith correct remaining percentages.Note: local screenshot files were used for verification but are not committed to the repo.