-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: gate CLI background usage fetch on confirmed-absent OAuth creds #2813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9076445
fix: gate CLI background usage fetch on confirmed-absent OAuth creds …
axisrow f7ddb5e
fix: require explicit background opt-in before the OAuth absence fall…
axisrow 401d9f2
fix: preserve original auth error during background Claude web recovery
axisrow 5614710
test: isolate identified Claude profile in baseline background-Auto t…
steipete cf87897
Merge remote-tracking branch 'origin/main' into upstream-pr-2708
steipete ebfbfb7
test: split explicit-mode Claude baseline tests into an extension
steipete 3d6edce
test: isolate identified Claude profile in upgrade-compat deadlock test
steipete File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a scheduled Auto refresh has an identifiable profile but no local OAuth cache/file, this return bypasses the existing foreground-establishment and
.alwaysprompt-policy gates.ClaudeCLIFetchStrategy.fetchthen uses the.clipath, which goes directly to the interactive PTY withoutClaudeCLIAuthStatusProbe; for a logged-out CLI this can open browser OAuth, and the opaque child can also surface Keychain UI, despite the refresh being in the background and the default policy beingonlyOnUserAction. A confirmed absence of CodexBar-readable credentials does not establish that the interactive CLI is safe to launch unattended, so this exception should still require explicit background opt-in or a noninteractive logged-in preflight.Useful? React with 👍 / 👎.