-
Notifications
You must be signed in to change notification settings - Fork 37
Add dedicated ZK skill for Protocol 25 X-Ray #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
047e70f
79b0181
d8dbca1
6c4bec1
0bb4612
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -109,6 +109,26 @@ For vulnerability patterns, checklists, and detailed tooling guides, see [securi | |||||
| - [CoinFabrik Audit Reports](https://www.coinfabrik.com/smart-contract-audit-reports/) | ||||||
| - [Certora Security Reports](https://github.com/Certora/SecurityReports) - Includes Stellar verifications | ||||||
|
|
||||||
| ## Zero-Knowledge Proofs (Protocol 25 X-Ray) | ||||||
|
|
||||||
| For comprehensive ZK development guidance, see [zk-proofs.md](zk-proofs.md). | ||||||
|
|
||||||
| ### Protocol & Specifications | ||||||
| - [X-Ray Announcement](https://stellar.org/blog/developers/announcing-stellar-x-ray-protocol-25) - Protocol 25 overview | ||||||
| - [CAP-0074](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0074.md) - BN254 elliptic curve specification | ||||||
| - [CAP-0075](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0075.md) - Poseidon hash function specification | ||||||
|
|
||||||
| ### SDK Documentation | ||||||
| - [Soroban SDK BN254](https://docs.rs/soroban-sdk/latest/soroban_sdk/crypto/bn254/) - BN254 types and functions | ||||||
| - [Soroban SDK Crypto](https://docs.rs/soroban-sdk/latest/soroban_sdk/crypto/) - Full crypto module reference | ||||||
|
|
||||||
| ### Proving Systems & Tooling | ||||||
| - [Noir Documentation](https://noir-lang.org/docs/) - Aztec's ZK domain-specific language | ||||||
| - [RISC Zero](https://dev.risczero.com/) - General-purpose zkVM for Rust programs | ||||||
|
|
||||||
| ### Example Contracts | ||||||
| - [Soroban Examples](https://github.com/stellar/soroban-examples) - Official examples (includes `groth16_verifier`, `privacy-pools`, `import_ark_bn254`) | ||||||
|
||||||
| - [Soroban Examples](https://github.com/stellar/soroban-examples) - Official examples (includes `groth16_verifier`, `privacy-pools`, `import_ark_bn254`) | |
| - [Soroban Examples](https://github.com/stellar/soroban-examples) - Official examples (e.g., `groth16_verifier`, `import_ark_bn254`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The soroban-examples repo has privacy pools: https://github.com/stellar/soroban-examples/tree/main/privacy-pools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reference to zk-proofs.md is helpful, but the BN254 API examples shown earlier in this section (lines 495-508) use a different API style than what's documented in zk-proofs.md. The old examples use method calls like
bn254.g1_add()while zk-proofs.md uses operator overloading likeG1Affine + G1Affine. Similarly, the Poseidon description at line 512 mentionsenv.crypto_hazmat()with ahazmatfeature flag, while zk-proofs.md showsenv.crypto().poseidon_hash(). Consider either updating the earlier examples in this section to match zk-proofs.md's API, or removing them entirely to avoid confusion since comprehensive guidance is now in the dedicated file.