Add support for S3 history archives in parallel catchup v2 - #326
Merged
Conversation
jacekn
reviewed
Oct 13, 2025
This PR contains the supercluster changes required to support stellar/ops#4190. It consists of 3 main changes: 1. Adds a `ServiceAccount` to the helm chart with configurable annotations. To set these annotations, use the new flag: ``` --service-account-annotations-pc-v2 <key1>:<val1> <key2>:<val2> ... ``` 2. Adds the worker `StatefulSet` to the new `ServiceAccount` 3. Adds support for overriding the history archive `get` commands to point to S3 with the new flag: ``` --s3-history-mirror-override-pc-v2 <base S3 url without s3:// prefix> ```
bboston7
force-pushed
the
history-mirror
branch
from
October 13, 2025 19:30
7f7a5a5 to
640a1eb
Compare
jacekn
approved these changes
Oct 14, 2025
jayz22
reviewed
Oct 14, 2025
jayz22
reviewed
Oct 14, 2025
…chup_workers.yaml Co-authored-by: Jay Geng <jay@stellar.org>
Contributor
|
As a followup to this work, should we update archive links in other missions to using S3 for cost saving? In that case, perhaps we can drop the "-pc-v2" suffix in the options in the future. |
Contributor
Yeah that could be nice. For other missions to use the S3 archive they would need to use a ServiceAccount with annotations. Small challenge with that is that all missions would need to use the same account. |
Contributor
Author
|
I opened #331 to capture that followup work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the supercluster changes required to support stellar/ops#4190. It consists of 3 main changes:
ServiceAccountto the helm chart with configurable annotations. To set these annotations, use the new flag:StatefulSetto the newServiceAccountgetcommands to point to S3 with the new flag:This is a draft PR because I can't test it without knowing what the right annotations are. However, I've looked at the generated Helm charts and they seem to match what ops is requesting. I'll mark this PR ready once @jacekn confirms these options work as expected.