Skip to content

Added dns config files for monitoring#293

Merged
varunsh-coder merged 3 commits into
step-security:rc-2from
h0x0er:issue291
Sep 25, 2022
Merged

Added dns config files for monitoring#293
varunsh-coder merged 3 commits into
step-security:rc-2from
h0x0er:issue291

Conversation

@h0x0er

@h0x0er h0x0er commented Sep 5, 2022

Copy link
Copy Markdown
Member

Closes #291

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #293 (ca30228) into int (664b526) will not change coverage.
The diff coverage is n/a.

❗ Current head ca30228 differs from pull request most recent head 50020a4. Consider uploading reports for the commit 50020a4 to get more accurate results

@@           Coverage Diff           @@
##              int     #293   +/-   ##
=======================================
  Coverage   68.35%   68.35%           
=======================================
  Files          14       14           
  Lines        1520     1520           
=======================================
  Hits         1039     1039           
  Misses        374      374           
  Partials      107      107           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@varunsh-coder varunsh-coder changed the base branch from int to rc-2 September 13, 2022 16:35
@varunsh-coder

Copy link
Copy Markdown
Member

Thanks @h0x0er!

Few changes are needed:

  1. Use the constants for the file names that are defined in dnsconfig.go2.
    dockerDaemonConfigPath = "/etc/docker/daemon.json"
  2. You need to also detect if the files changed. If they did, add an annotation. See the below code for where this needs to be done.
    if strings.Contains(event.FileName, "post_event.json") {

@varunsh-coder varunsh-coder merged commit 06e1e15 into step-security:rc-2 Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants