Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
adthrasher
left a comment
adthrasher
left a comment
There was a problem hiding this comment.
All of these comments are based on the first commit.
adthrasher
left a comment
adthrasher
left a comment
There was a problem hiding this comment.
Comments based on the second commit.
adthrasher
left a comment
adthrasher
left a comment
There was a problem hiding this comment.
I think this is in good enough shape. There are still some cases we could (and should) improve, but I think it's close enough for now to start enforcing this on our repo.
_Describe the problem or feature in addition to a link to the issues._ Before submitting this PR, please make sure: - [ ] You have added a few sentences describing the PR here. - [ ] The code passes all CI tests without any errors or warnings. - [ ] You have added tests (when appropriate). - [ ] You have added an entry in any relevant CHANGELOGs (when appropriate). - [ ] If you have made any changes to the `scripts/` or `docker/` directories, please ensure any image versions have been incremented accordingly! - [ ] You have updated the README or other documentation to account for these changes (when appropriate).
3 participants
Describe the problem or feature in addition to a link to the issues.
Before submitting this PR, please make sure:
scripts/ordocker/directories, please ensure any image versions have been incremented accordingly!