This repository was archived by the owner on Jun 29, 2025. It is now read-only.
feat(MyShares): show information about own share security options#720
Merged
stonith404 merged 9 commits intostonith404:mainfrom Dec 31, 2024
Merged
feat(MyShares): show information about own share security options#720stonith404 merged 9 commits intostonith404:mainfrom
stonith404 merged 9 commits intostonith404:mainfrom
Conversation
stonith404
reviewed
Dec 31, 2024
…are into share-show-security
…ngvin-share into share-show-security
Owner
|
Great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shows a password protection indicator of password protected shares and the max visitor count for shares with such a limit.
This exposes the max visitor count and whether a share has a password or not in the
getSharesByUserfunction of the share service. I just assumed that when you are able to get that information from the API as a user that it is either info about your own shares or it is okay to also get that information returned (i.e. site admins). Please let me know if that is not the case.