fix: No giant upload/add receipts

[Peeja]

Don't repeat the list of shards in the upload/add OK value. It's optional, it's unnecessary, and it's problematically large for very large uploads.

Note that this change only affects the test. w3infra then needs a corresponding change to implement this correctly.

PR Dependency Tree

• PR fix: No giant upload/add receipts #671 👈

This tree was auto-generated by Charcoal

[frrist]

I am concerned this may break clients who fail to treat this value as optional on the hot network, but understand we need this to unblock forge. Could we include a check here such that we continue returning the shards when the list isn't unreasonably long, and only omit when it reaches a certain threshold?

[Peeja]

I don't feel super comfortable catering to potential clients that could be relying on a misunderstanding of the spec, when almost no one uses a client we didn't write. AFAICT, there's no good reason for the shards to be there in the first place, nor the root for that matter. A receipt is already tied to an invocation; unless there's a chance of the values being different, it's silly to duplicate the values. I would be surprised if anyone could come up with a reason to have used the values in the out in the first place.