fix: Find the receipts URL from the connection URL#1565
Merged
Conversation
alanshaw
approved these changes
Oct 18, 2024
We were defaulting to the production URL unless a `receiptsEndpoint` was given in the options, and then never providing one. Passing it along would probably be the better solution, but there are a lot of places to get that wrong as things stand right now. It's not clear to me where the receipt URL really should live--eg., whether it should properly be part of the connection config.
Peeja
force-pushed
the
get-receipts-in-non-prod
branch
from
2228d76 to
da6a842
Compare
alanshaw
pushed a commit
that referenced
this pull request
Nov 29, 2024
🤖 I have created a release *beep* *boop* --- ## [17.1.1](upload-client-v17.1.0...upload-client-v17.1.1) (2024-11-29) ### Fixes * Find the receipts URL from the connection URL ([#1565](#1565)) ([3eb0f8e](3eb0f8e)) * overflow slices ([#1595](#1595)) ([0731582](0731582)) ### Other Changes * **main:** release w3up-client 16.4.1 ([#1577](#1577)) ([1482d69](1482d69)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
fforbeck
added a commit
to storacha/upload-service
that referenced
this pull request
Jan 16, 2025
tx-ravenxbsw3
added a commit
to tx-ravenxbsw3/w3up
that referenced
this pull request
Sep 29, 2025
🤖 I have created a release *beep* *boop* --- ## [17.1.1](storacha/w3up@upload-client-v17.1.0...upload-client-v17.1.1) (2024-11-29) ### Fixes * Find the receipts URL from the connection URL ([#1565](storacha/w3up#1565)) ([3eb0f8e](storacha/w3up@3eb0f8e)) * overflow slices ([#1595](storacha/w3up#1595)) ([0731582](storacha/w3up@0731582)) ### Other Changes * **main:** release w3up-client 16.4.1 ([#1577](storacha/w3up#1577)) ([1482d69](storacha/w3up@1482d69)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were defaulting to the production URL unless a
receiptsEndpointwas given in the options, and then never providing one. Passing it along would probably be the better solution, but there are a lot of places to get that wrong as things stand right now. It's not clear to me where the receipt URL really should live--eg., whether it should properly be part of the connection config.