Skip to content

Core: Allow string in object arg and support fractional numbers in URL args#14511

Merged
shilman merged 5 commits intonextfrom
laxer-url-params
Apr 8, 2021
Merged

Core: Allow string in object arg and support fractional numbers in URL args#14511
shilman merged 5 commits intonextfrom
laxer-url-params

Conversation

@ghengeveld
Copy link
Member

Issue: #14508

What I did

  • Add support for fractional numbers in URL args
  • Allow raw strings and numbers when parsing object arg param (e.g. for ReactNode)

How to test

  • Is this testable with Jest or Chromatic screenshots? no
  • Does this need a new example in the kitchen sink apps? no
  • Does this need an update to the documentation? no

If your answer is yes to any of these, please make sure to include it in your PR.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit 36b34d8 into next Apr 8, 2021
@shilman shilman deleted the laxer-url-params branch April 8, 2021 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants