Maintenance: Migrate @storybook/preset-create-react-app to strict TS#22395
Merged
ndelangen merged 16 commits intostorybookjs:release-8-0from Nov 27, 2023
Merged
Maintenance: Migrate @storybook/preset-create-react-app to strict TS#22395ndelangen merged 16 commits intostorybookjs:release-8-0from
@storybook/preset-create-react-app to strict TS#22395ndelangen merged 16 commits intostorybookjs:release-8-0from
Conversation
kuriacka
changed the title
kasperpeulen
requested changes
May 31, 2023
Contributor
kasperpeulen
left a comment
kasperpeulen
left a comment
There was a problem hiding this comment.
Looks good, only one thing that confuses me!
kasperpeulen
changed the title
kasperpeulen
requested review from
ndelangen and
valentinpalkovic
as code owners
ndelangen
changed the title
@storybook/preset-create-react-app to strict TS
Member
|
@kuriacka could you check the CI, and fix any remaining issues? |
Contributor
Author
@ndelangen Sure, I created this PR a while ago, but I will do my best. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #22176
What I did
Migrate
@storybook/create-react-appto strict-tsHow to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]