Skip to content

TestBuild: Revert defaulting to SWC in test build, but keep using esbuild for minification#24843

Merged
kasperpeulen merged 2 commits intonextfrom
kasper/revert-swc-from-test-build
Nov 14, 2023
Merged

TestBuild: Revert defaulting to SWC in test build, but keep using esbuild for minification#24843
kasperpeulen merged 2 commits intonextfrom
kasper/revert-swc-from-test-build

Conversation

@kasperpeulen
Copy link
Contributor

What I did

Revert defaulting to SWC in test build, but keep using esbuild for minification

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@kasperpeulen kasperpeulen merged commit 0e1f152 into next Nov 14, 2023
@kasperpeulen kasperpeulen deleted the kasper/revert-swc-from-test-build branch November 14, 2023 20:20
@github-actions github-actions bot mentioned this pull request Nov 14, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant