UI: Fix sidebar top and bottom addon slots#25426
Merged
Conversation
ndelangen
requested review from
JReinhold,
cdedreuille and
tmeasday
as code owners
shilman
reviewed
Jan 3, 2024
| const bottomItems = api.getElements(Addon_TypesEnum.experimental_SIDEBAR_BOTTOM); | ||
| const topItems = api.getElements(Addon_TypesEnum.experimental_SIDEBAR_TOP); | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| const bottom = useMemo(() => Object.values(bottomItems), [...Object.values(bottomItems)]); |
Member
There was a problem hiding this comment.
What is the point of this kind of memoization???
Member
Author
There was a problem hiding this comment.
You get the same array every time, unless bottomItems has new properties/values.
Member
There was a problem hiding this comment.
Ok, so it's about preserving instance equality of the array so that the consuming UI does not re-render unnecessarily?
shilman
approved these changes
Jan 6, 2024
shilman
changed the title
shilman
changed the title
This was referenced Jan 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25404
What I did
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>