Docs: Fix MDX Stories block tag-filtering behavior#27144
Merged
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit babad72. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
JReinhold
approved these changes
May 15, 2024
storybook-bot
pushed a commit
that referenced
this pull request
May 15, 2024
…block-in-mdx Docs: Fix MDX Stories block tag-filtering behavior (cherry picked from commit ce3d0d5)
This was referenced May 15, 2024
Merged
storybook-bot
pushed a commit
that referenced
this pull request
May 15, 2024
…block-in-mdx Docs: Fix MDX Stories block tag-filtering behavior (cherry picked from commit ce3d0d5)
storybook-bot
pushed a commit
that referenced
this pull request
May 15, 2024
…block-in-mdx Docs: Fix MDX Stories block tag-filtering behavior (cherry picked from commit ce3d0d5)
Closed
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27143
What I did
Made a sneaky change to the tag-based filtering of
autodocsintroduced in 8.1, which was an unintentional breaking change for users who used theStoriesdoc block in MDX pages.Now if NONE of the stories have the autodocs tag (which is only possible in an MDX page), it will show ALL of the stories in the
Storiesblock.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
You can check the added stories:
You can also reproduce this in a sandbox by adding
Button.mdxand playing around with the tags inButton.stories.ts:🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>