UI: Fix controls and parameters on tag-filtered stories#30038
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
9 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
| indexError: undefined, | ||
| }); | ||
| }, | ||
| // FIXME: is there a bug where filtered stories get added back in on updateStory??? |
Contributor
There was a problem hiding this comment.
logic: This FIXME comment identifies a real issue - filtered stories could get re-added during updates. Consider adding a check to prevent this.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6dc2790. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
shilman
force-pushed
the
shilman/fix-tag-filtered-controls
branch
from
85af220 to
bea7aec
Compare
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 59 | 59 | 0 |
| Self size | 411 KB | 45 KB | 🎉 -366 KB 🎉 |
| Dependency size | 13.46 MB | 13.46 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
@storybook/addon-onboarding
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 0 | 2 | 🚨 +2 🚨 |
| Self size | 235 KB | 216 KB | 🎉 -19 KB 🎉 |
| Dependency size | 670 B | 235 KB | 🚨 +235 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/experimental-nextjs-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 153 | 87 | 🎉 -66 🎉 |
| Self size | 231 KB | 231 KB | 🎉 -16 B 🎉 |
| Dependency size | 44.67 MB | 31.57 MB | 🎉 -13.10 MB 🎉 |
| Bundle Size Analyzer | Link | Link |
shilman
force-pushed
the
shilman/fix-tag-filtered-controls
branch
from
bea7aec to
56f5220
Compare
shilman
force-pushed
the
shilman/fix-tag-filtered-controls
branch
from
56f5220 to
6dc2790
Compare
17 tasks
shilman
added
the
needs qa
yannbf
removed
the
needs qa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29827
What I did
Refactor the manager to include a full stories hash and a filtered stories hash. Show the filtered hash in the sidebar but use the full stories hash for storing parameters etc.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
This PR refactors Storybook's manager to maintain both full and filtered story indexes, ensuring Controls panel functionality remains intact when stories are filtered by tags in the sidebar.
filteredIndexfield toAPI_LoadedRefDatainterface incode/core/src/types/modules/api.tssetIndexincode/core/src/manager-api/modules/stories.tsto maintain both filtered and unfiltered story hashesfilteredIndexfor display while preserving full story data for Controlscode/core/src/manager-api/tests/stories.test.tsfor filtered index functionalitycode/core/src/manager-api/modules/refs.ts