Release: Patch 8.6.13#31492
Closed
github-actions[bot] wants to merge 8 commits intolatest-releasefrom
Closed
Conversation
…ate-param Core: Fix using dates in expect statements (cherry picked from commit 1bdc69c)
Test: Make sure that lit arrays are not cloned (cherry picked from commit 6f91cee)
CLI: Add skip onboarding, recommended/minimal config (cherry picked from commit dde78a0)
Controls: Fix boxShadow on empty controls (cherry picked from commit ebd2976)
Docs: Replace outdated MDX VSCode setting with a new one (cherry picked from commit 1137866)
Dependencies: Update `react-native-web` (cherry picked from commit c92d13b)
React Native Web: Fix expo router by setting JSX to automatic (cherry picked from commit 50b17fa)
github-actions
bot
added
the
release
github-actions
bot
requested review from
jonniebigodes and
kylegach
as code owners
github-actions
bot
added
the
release
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
28 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+48
to
+51
| /** | ||
| * A class for reading and writing settings from a JSON file. Supports nested settings with dot | ||
| * notation. | ||
| */ |
Contributor
There was a problem hiding this comment.
logic: Comment mentions dot notation support but implementation appears to be missing this functionality
| settings = { | ||
| value: { version: 1 }, | ||
| save: vi.fn(), | ||
| } as any as Settings; |
Contributor
There was a problem hiding this comment.
style: Type assertion could be replaced with proper type definition
Comment on lines
+141
to
+150
| it('uses specific prompt options for React Native projects', async () => { | ||
| prompts.inject(['recommended']); | ||
| const result = await promptInstallType({ | ||
| settings, | ||
| projectType: ProjectType.REACT_NATIVE, | ||
| }); | ||
|
|
||
| expect(result).toBe('recommended'); | ||
| expect(prompts).not.toHaveBeenCalled(); | ||
| expect(vi.mocked(telemetry).mock.calls[0][1]).toMatchInlineSnapshot(` |
Contributor
There was a problem hiding this comment.
logic: Test case doesn't match behavior - says it uses specific prompt options but expects prompts not to be called
Suggested change
| it('uses specific prompt options for React Native projects', async () => { | |
| prompts.inject(['recommended']); | |
| const result = await promptInstallType({ | |
| settings, | |
| projectType: ProjectType.REACT_NATIVE, | |
| }); | |
| expect(result).toBe('recommended'); | |
| expect(prompts).not.toHaveBeenCalled(); | |
| expect(vi.mocked(telemetry).mock.calls[0][1]).toMatchInlineSnapshot(` | |
| it('skips prompts for React Native projects', async () => { | |
| prompts.inject(['recommended']); | |
| const result = await promptInstallType({ | |
| settings, | |
| projectType: ProjectType.REACT_NATIVE, | |
| }); | |
| expect(result).toBe('recommended'); | |
| expect(prompts).not.toHaveBeenCalled(); | |
| expect(vi.mocked(telemetry).mock.calls[0][1]).toMatchInlineSnapshot(` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
8.6.12to8.6.13.Once this pull request is merged, it will trigger a new release of version
8.6.13.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:react-native-web#31324🍒 Manual cherry picking needed!
The following pull requests could not be cherry-picked automatically because it resulted in merge conflicts.
For each pull request below, you need to either manually cherry pick it, or discard it by replacing the "patch:yes" label with "patch:no" on the PR and re-generate this PR.
git cherry-pick -m1 -x 1bdc69c1f3035e6fb832472e2bba7605e6e99163git cherry-pick -m1 -x 6f91cee5640075188cbb05b1e4a1aab5f7804c64git cherry-pick -m1 -x dde78a0a694a88d9cfe4f916de62f97141495226If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.6.13
react-native-web- #31324, thanks @ndelangen!Greptile Summary
This patch release (8.6.13) includes multiple bug fixes and improvements across CLI onboarding, controls styling, date handling, and React Native Web compatibility.
code/lib/create-storybook/src/initiate.tswith options for recommended/minimal configurationscode/lib/blocks/src/components/ArgsTable/Empty.tsxcode/frameworks/react-native-web-vite/src/preset.tsto use automatic JSX runtimecode/lib/test/src/index.tsto prevent lit array cloning issuescode/core/src/cli/globalSettings.tsfor persisting user preferences