Conversation
There was a problem hiding this comment.
23 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
| const error = new Error() as Error & { code: string }; | ||
| error.code = 'ENOENT'; |
There was a problem hiding this comment.
style: Type assertion could be replaced with a proper error type definition
| const content = await fs.readFile(filePath, 'utf8'); | ||
| const settingsValue = userSettingSchema.parse(JSON.parse(content)); | ||
| settings = new Settings(filePath, settingsValue); | ||
| } catch (err: any) { |
There was a problem hiding this comment.
style: Avoid using 'any' type for error handling. Use 'unknown' instead for better type safety.
| } catch (err: any) { | |
| } catch (err: unknown) { |
| settings = { | ||
| value: { version: 1 }, | ||
| save: vi.fn(), | ||
| } as any as Settings; |
There was a problem hiding this comment.
style: Type assertion could be replaced with proper type definition
| expect(result).toBe('recommended'); | ||
| expect(prompts).not.toHaveBeenCalled(); |
There was a problem hiding this comment.
logic: These expectations seem contradictory - expecting both a result and prompts to not have been called
|
View your CI Pipeline Execution ↗ for commit 4df77ca.
☁️ Nx Cloud last updated this comment at |
React Native Web: Fix expo router by setting JSX to automatic (cherry picked from commit 50b17fa)
b0ed520 to
298fdff
Compare
There was a problem hiding this comment.
24 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| value: { version: 1 }, | ||
| save: vi.fn(), | ||
| } as any as Settings; |
There was a problem hiding this comment.
style: Consider moving settings object into beforeEach to ensure clean state between tests
This is an automated pull request that bumps the version from
8.6.13to8.6.14.Once this pull request is merged, it will trigger a new release of version
8.6.14.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:🍒 Manual cherry picking needed!
The following pull requests could not be cherry-picked automatically because it resulted in merge conflicts.
For each pull request below, you need to either manually cherry pick it, or discard it by replacing the "patch:yes" label with "patch:no" on the PR and re-generate this PR.
git cherry-pick -m1 -x 1bdc69c1f3035e6fb832472e2bba7605e6e99163git cherry-pick -m1 -x 6f91cee5640075188cbb05b1e4a1aab5f7804c64git cherry-pick -m1 -x dde78a0a694a88d9cfe4f916de62f97141495226If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.6.14
Greptile Summary
This patch release (8.6.14) includes several bug fixes and improvements across multiple areas of Storybook, with significant updates to the CLI onboarding experience and global settings management.
code/lib/create-storybook/src/initiate.tswith options for recommended/minimal configurationscode/core/src/cli/globalSettings.tsfor persistent user preferencescode/addons/test/src/components/MethodCall.tsxfor expect statementscode/lib/test/src/index.ts