Skip to content

Release: Patch 8.6.14#31494

Merged
shilman merged 12 commits intolatest-releasefrom
version-patch-from-8.6.13
May 16, 2025
Merged

Release: Patch 8.6.14#31494
shilman merged 12 commits intolatest-releasefrom
version-patch-from-8.6.13

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented May 16, 2025

This is an automated pull request that bumps the version from 8.6.13 to 8.6.14.
Once this pull request is merged, it will trigger a new release of version 8.6.14.
If you're not a core maintainer with permissions to release you can ignore this pull request.

To do

Before merging the PR, there are a few QA steps to go through:

  • Add the "freeze" label to this PR, to ensure it doesn't get automatically forced pushed by new changes.
  • Add the "ci:daily" label to this PR, to trigger the full test suite to run on this PR.

And for each change below:

  1. Ensure the change is appropriate for the version bump. E.g. patch release should only contain patches, not new or de-stabilizing features. If a change is not appropriate, revert the PR.
  2. Ensure the PR is labeled correctly with one of: "BREAKING CHANGE", "feature request", "bug", "maintenance", "dependencies", "documentation", "build", "unknown".
  3. Ensure the PR title is correct, and follows the format "[Area]: [Summary]", e.g. "React: Fix hooks in CSF3 render functions". If it is not correct, change the title in the PR.
    • Areas include: React, Vue, Core, Docs, Controls, etc.
    • First word of summary indicates the type: “Add”, “Fix”, “Upgrade”, etc.
    • The entire title should fit on a line

This is a list of all the PRs merged and commits pushed directly to next, that will be part of this release:

  • 🐛 Bug: Core: Fix using dates in expect statements #28413
  • 🐛 Bug: Test: Make sure that lit arrays are not cloned #31435
  • 🔧 Maintenance: CLI: Add skip onboarding, recommended/minimal config #30930
  • 🐛 Bug: React Native Web: Fix expo router by setting JSX to automatic #31484

🍒 Manual cherry picking needed!

The following pull requests could not be cherry-picked automatically because it resulted in merge conflicts.
For each pull request below, you need to either manually cherry pick it, or discard it by replacing the "patch:yes" label with "patch:no" on the PR and re-generate this PR.

  • #28413: git cherry-pick -m1 -x 1bdc69c1f3035e6fb832472e2bba7605e6e99163
  • #31435: git cherry-pick -m1 -x 6f91cee5640075188cbb05b1e4a1aab5f7804c64
  • #30930: git cherry-pick -m1 -x dde78a0a694a88d9cfe4f916de62f97141495226

If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.

Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.

When everything above is done:


Generated changelog

8.6.14

Greptile Summary

This patch release (8.6.14) includes several bug fixes and improvements across multiple areas of Storybook, with significant updates to the CLI onboarding experience and global settings management.

  • Added new CLI onboarding flow in code/lib/create-storybook/src/initiate.ts with options for recommended/minimal configurations
  • Added global settings system in code/core/src/cli/globalSettings.ts for persistent user preferences
  • Fixed date handling in code/addons/test/src/components/MethodCall.tsx for expect statements
  • Fixed Lit array cloning issue in code/lib/test/src/index.ts
  • Updated React Native Web Vite preset to use automatic JSX runtime

ghengeveld and others added 5 commits May 14, 2025 11:44
…ate-param

Core: Fix using dates in expect statements
(cherry picked from commit 1bdc69c)
Test: Make sure that lit arrays are not cloned
(cherry picked from commit 6f91cee)
CLI: Add skip onboarding, recommended/minimal config
(cherry picked from commit dde78a0)
@github-actions github-actions bot requested a review from kylegach as a code owner May 16, 2025 03:36
@github-actions github-actions bot added the release For PRs that trigger new releases. Automated label May 16, 2025
@github-actions github-actions bot requested a review from jonniebigodes as a code owner May 16, 2025 03:36
@github-actions github-actions bot added the release For PRs that trigger new releases. Automated label May 16, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

23 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile

Comment on lines +58 to +59
const error = new Error() as Error & { code: string };
error.code = 'ENOENT';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Type assertion could be replaced with a proper error type definition

const content = await fs.readFile(filePath, 'utf8');
const settingsValue = userSettingSchema.parse(JSON.parse(content));
settings = new Settings(filePath, settingsValue);
} catch (err: any) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Avoid using 'any' type for error handling. Use 'unknown' instead for better type safety.

Suggested change
} catch (err: any) {
} catch (err: unknown) {

settings = {
value: { version: 1 },
save: vi.fn(),
} as any as Settings;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Type assertion could be replaced with proper type definition

Comment on lines +148 to +149
expect(result).toBe('recommended');
expect(prompts).not.toHaveBeenCalled();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: These expectations seem contradictory - expecting both a result and prompts to not have been called

@nx-cloud
Copy link

nx-cloud bot commented May 16, 2025

View your CI Pipeline Execution ↗ for commit 4df77ca.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 2m 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-16 10:33:23 UTC

shilman and others added 2 commits May 16, 2025 08:47
React Native Web: Fix expo router by setting JSX to automatic

(cherry picked from commit 50b17fa)
@storybook-bot storybook-bot force-pushed the version-patch-from-8.6.13 branch from b0ed520 to 298fdff Compare May 16, 2025 08:48
@shilman shilman reopened this May 16, 2025
@shilman shilman added the freeze Freeze the Release PR with this label label May 16, 2025
@shilman shilman added the ci:daily Run the CI jobs that normally run in the daily job. label May 16, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

24 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Comment on lines +93 to +95
value: { version: 1 },
save: vi.fn(),
} as any as Settings;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider moving settings object into beforeEach to ensure clean state between tests

@shilman shilman merged commit f925116 into latest-release May 16, 2025
98 of 100 checks passed
@shilman shilman deleted the version-patch-from-8.6.13 branch May 16, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:daily Run the CI jobs that normally run in the daily job. freeze Freeze the Release PR with this label release For PRs that trigger new releases. Automated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants