feat: AdMobバナー広告の導入#148
Merged
Merged
Conversation
Collaborator
snapshotの変更更新ファイル:
|
| before | after |
|---|---|
 |
 |
更新ファイル: AppTabView_0-iPhone-SE-2nd-generation.1.png
| before | after |
|---|---|
 |
 |
Generated by 🚫 Danger Swift against e084a22
Collaborator
Generated by 🚫 Danger Swift against e084a22 |
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Xcode CloudへCD移行に伴い、cd_release.yml/cd_testFlight.ymlは不要になったため削除する。 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
ci: Xcode CloudのCIスクリプトをワークフロー別に分岐させる
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
経緯
実装内容
AdMob SDK の導入
GoogleMobileAdsを SPM 依存に追加し、MobileAdsClientを経由してアプリ起動時に初期化するHometeAppに組み込み広告ユニットIDの管理方針
BannerType.unitIdで Info.plist のAdUnitIdList辞書から該当キーの値を取得Admob.xcconfigはリポジトリ管理外（.gitignore済み）。Admob_dev.xcconfigはサンプルIDのみ含むためリポジトリ管理に残す依存関係の整理
AdComponentResolverをHometeDomain側に置き、HometeUI経由で各 Feature から広告コンポーネントを参照できるように整理HometeInfrastructure/GoogleMobileAdsに直接依存しないようにし、モジュール境界とテスト容易性を保つため表示・テスト
HomeViewのダッシュボード上部にバナー広告を配置（現状はテストモードのサンプルユニットID）確認内容
HomeViewのダッシュボード上部にバナー広告が表示されることAdmob.xcconfig（本番ID）がリポジトリに含まれていないこと