Skip to content

Inconsistent naming of signalrport/signalport affecting StraxUI use case #475

@TjadenFroyda

Description

@TjadenFroyda

The discussion on discord re RPi staking reminded me of an issue with a specific use case.

I run a headless RPi for strax staking and connect to it with StraxUI through the daemonip flag. Daemon runs on the RPi and then I connect to it from a local device when I want to make a transaction, etc. This issue would also affect Cirrus/InterFlux if used in the same manner.

When StraxUI was changed to use signalR, certain elements on the UI didn't show (i.e. balance, transactions) when used with daemonip. I was able to track this down to a difference in naming the signalRport between StraxUI and the StratisFullNode, which resulted in the SignalRPort interface in StraxUI being null on inspection.

StratisFullNode
SignalRController.cs
L#35
this.signalRSettings.SignalPort

SignalRSettings.cs
L#45, L#50
this.SignalPort = port;
Does not affect the above, just another area where naming is inconsistent.

StraxUI
signalrs-service.ts
L#15
signalRPort: string; This is null when getConnectionInfo is called (if uncommented), expecting signalrport, but signalport is received from signalrcontroller.

A small change in the StratisFullNode SignalRController fixes the issue and then this line in StraxUI could be uncommented to allow that functionality.

May I submit a PR to update?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions