Skip to content

Pass ChainIndexer argument via CachedCoinView constructor#1072

Merged
quantumagi merged 4 commits intostratisproject:release/1.4.0.0from
quantumagi:passchainindexertoconstr
Oct 11, 2022
Merged

Pass ChainIndexer argument via CachedCoinView constructor#1072
quantumagi merged 4 commits intostratisproject:release/1.4.0.0from
quantumagi:passchainindexertoconstr

Conversation

@quantumagi
Copy link
Contributor

@quantumagi quantumagi commented Oct 7, 2022 •
edited
Loading

This PR:

  • Adds ChainIndexer from the CachedCoinView constructor
  • Removes ChainIndexer and chainTip from the CachedCoinView's Initialize and Sync methods.
  • Adds locks to public methods that lack them.

@quantumagi quantumagi requested a review from zeptin October 7, 2022 07:01
@quantumagi quantumagi requested review from zeptin and removed request for zeptin October 10, 2022 06:22
@quantumagi quantumagi merged commit cdcc14c into stratisproject:release/1.4.0.0 Oct 11, 2022
quantumagi added a commit to quantumagi/StratisFullNode-1 that referenced this pull request Jan 31, 2023
@quantumagi
Pass ChainIndexer argument via CachedCoinView constructor (stratispro…
1ef2dd5 
…ject#1072)

* Pass ChainIndexer argument via CachedCoinView constructor

* Add this

* Add missing locks

* Refactor

(cherry picked from commit cdcc14c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zeptin zeptin zeptin approved these changes

Assignees

No one assigned

Labels

1.4.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@quantumagi @zeptin