Add collateral height checks to miner and rules#1073
Merged
fassadlr merged 8 commits intostratisproject:release/1.3.2.4from Oct 12, 2022
Merged
Add collateral height checks to miner and rules#1073fassadlr merged 8 commits intostratisproject:release/1.3.2.4from
fassadlr merged 8 commits intostratisproject:release/1.3.2.4from
Conversation
fassadlr
reviewed
Oct 11, 2022
fassadlr
reviewed
Oct 11, 2022
fassadlr
reviewed
Oct 11, 2022
fassadlr
reviewed
Oct 11, 2022
Contributor
fassadlr
left a comment
fassadlr
left a comment
There was a problem hiding this comment.
PR looks good, just add a few small comments and possibly that unit test.
Contributor
|
PS does this test |
Contributor
Author
No. This is why I suggested in slack that PR 1070 (it fixes PR 1061) be added to this branch: https://stratisgroupworkspace.slack.com/archives/C9TGSJF0B/p1665475594037539 See PR #1074 |
Co-authored-by: Francois de la Rouviere <fassadlr@gmail.com>
Co-authored-by: Francois de la Rouviere <fassadlr@gmail.com>
…gi/StratisFullNode-1 into collateralheightchecks2
fassadlr
approved these changes
Oct 12, 2022
Contributor
fassadlr
left a comment
fassadlr
left a comment
There was a problem hiding this comment.
Looks good! Lets wait for CI 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
CheckCollateralCommitmentHeightRulerule it checks that the commitment height encoded for each block is greater or equal to the commitment height of the preceding block.