Add consolidate endpoint and adjust subtractfee logic#235
Merged
fassadlr merged 3 commits intostratisproject:masterfrom Nov 30, 2020
Merged
Add consolidate endpoint and adjust subtractfee logic#235fassadlr merged 3 commits intostratisproject:masterfrom
fassadlr merged 3 commits intostratisproject:masterfrom
Conversation
Collaborator
Author
|
Testnet consolidation within single address: https://chainz.cryptoid.info/strax-test/tx.dws?305911.htm Testnet consolidation within wallet account: https://chainz.cryptoid.info/strax-test/block.dws?133765.htm |
zeptin
commented
Nov 29, 2020
fassadlr
approved these changes
Nov 30, 2020
fassadlr
pushed a commit
that referenced
this pull request
Nov 30, 2020
* Add consolidate endpoint and adjust subtractfee logic * Fix and augment tests * Update src/Stratis.Bitcoin.Features.Wallet/Services/WalletService.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a useful function for managing wallets with large numbers of UTXOs.
There was also an undesired limitation on the
SubtractFeeFromAmountflag whereby it required theTransactionFeeto be set on the build context. This relaxes that requirement, but only when a single recipient has the flag set. Fortunately, many common use cases only need a single recipient to have the flag set.