Implement importpubkey RPC and watchonly flag for gettransaction#236
Merged
fassadlr merged 1 commit intostratisproject:masterfrom Nov 30, 2020
Merged
Implement importpubkey RPC and watchonly flag for gettransaction#236fassadlr merged 1 commit intostratisproject:masterfrom
fassadlr merged 1 commit intostratisproject:masterfrom
Conversation
quantumagi
reviewed
Nov 30, 2020
| if (!addressDict.TryGetValue(addressIdentifier, out HdAddress hdAddress)) | ||
| { | ||
| ExtPubKey extPubKey = ExtPubKey.Parse(hdAccount.ExtendedPubKey, this.Network); | ||
| string pubKeyHex = null; |
Contributor
There was a problem hiding this comment.
Looks good. In fact, the code added for watch-only-accounts may work equally well for the general case.
Contributor
|
I will fx the failing test in another PR. |
fassadlr
pushed a commit
that referenced
this pull request
Nov 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the
importpubkeyRPC call (this can later be extended into the fullimportaddress). Pubkeys that are imported in this way are added to a special-purpose watch only account for later lookup.Also adds the
include_watchonlyflag to thegettransactionRPC call. If this is set the watch only account is included in the search locations for the requested transaction ID.