Collapse CollateralFederationManager and FederationManager Part #1#272
Merged
fassadlr merged 2 commits intostratisproject:masterfrom Dec 11, 2020
Merged
Collapse CollateralFederationManager and FederationManager Part #1#272fassadlr merged 2 commits intostratisproject:masterfrom
fassadlr merged 2 commits intostratisproject:masterfrom
Conversation
quantumagi
reviewed
Dec 11, 2020
| var collateralFederationMember = new CollateralFederationMember(minerKey.PubKey, false, joinRequest.CollateralAmount, request.CollateralAddress); | ||
|
|
||
| byte[] federationMemberBytes = (this.network.Consensus.ConsensusFactory as CollateralPoAConsensusFactory).SerializeFederationMember(collateralFederationMember); | ||
| Poll poll = this.votingManager.GetFinishedPolls().FirstOrDefault(x => x.IsExecuted && |
Contributor
There was a problem hiding this comment.
Perhaps change this to order by poll height and take the last match with LastOrDefault. Same for the similar code in JoinFederationRequestMonitor.
quantumagi
approved these changes
Dec 11, 2020
Contributor
quantumagi
left a comment
quantumagi
left a comment
There was a problem hiding this comment.
LGTM. Just one comment/change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first PR, just to do the move. After this we will do more cleanup of various daemons and add rules back etc.