Use BlockTime rather than Time#416
Merged
quantumagi merged 7 commits intostratisproject:masterfrom Feb 18, 2021
Merged
Conversation
fassadlr
reviewed
Feb 16, 2021
Contributor
fassadlr
left a comment
fassadlr
left a comment
There was a problem hiding this comment.
Looks good, is this backward compatible with the current code? It appears that way... just want you to confirm.
src/Stratis.Bitcoin.Features.PoA/BasePoAFeatureConsensusRules/HeaderTimeChecksPoARule.cs
Show resolved
Hide resolved
|
|
||
| // Look at the last round of blocks to find the previous time that the miner mined. | ||
| uint roundTime = this.slotsManager.GetRoundLengthSeconds(federation.Count); | ||
| var roundTime = TimeSpan.FromSeconds(this.slotsManager.GetRoundLengthSeconds(federation.Count)); |
Contributor
There was a problem hiding this comment.
Doesn't GetRoundLengthSeconds already return seconds? Or are you doing TimeSpan cause of the uint return?
Contributor
Author
There was a problem hiding this comment.
TimeSpan is more granular than seconds.
Contributor
There was a problem hiding this comment.
Why dont we then just refactor GetRoundLengthSeconds to return TimeSpan?
Contributor
Author
Yes, that is the intent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving to faster block times may mean that
BlockTimecould include fractional seconds in the future.Since using
BlockTimeversusTimeis still logically equivalent we may as well already be usingBlockTimeinstead..So why this PR? The purpose is to make the future PoA v2 PR smaller by addressing trivial (non-logic-changing) updates separately.
There will be future PRs involving mining timestamp (and the use of
BlockTimeinstead ofTime) such as an updated #310.