Skip to content

[Cirrus] Implement ability to reconstruct the federation from a given height.#435

Merged
fassadlr merged 8 commits intostratisproject:masterfrom
fassadlr:init-votingmgr
Feb 22, 2021
Merged

[Cirrus] Implement ability to reconstruct the federation from a given height.#435
fassadlr merged 8 commits intostratisproject:masterfrom
fassadlr:init-votingmgr

Conversation

@fassadlr
Copy link
Contributor

Currently this needs to be done from before the multisig has been removed.

@quantumagi
Copy link
Contributor

quantumagi commented Feb 22, 2021

The code seems a bit risky in the way it modifies the existing list of polls while the node is running. Would it be possible to make the changes on a separate list and switch to this list only when done?

Alternatively (or in addition?), one could focus on making the polls repository more robust, similar to other repositories using tips, rewind etc.

@fassadlr
Copy link
Contributor Author

The code seems a bit risky in the way it modifies the existing list of polls while the node is running. Would it be possible to make the changes on a separate list and switch to this list only when done?

Alternatively (or in addition?), one could focus on making the polls repository more robust, similar to other repositories using tips, rewind etc.

Good points @quantumagi, we definitely need to improve on the polls repo to bring in tips etc. To me this is a OK for now until we do that work. I'm going to add to board.

@quantumagi quantumagi self-requested a review February 22, 2021 09:24
Copy link
Contributor

@quantumagi quantumagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fassadlr fassadlr merged commit 6964a35 into stratisproject:master Feb 22, 2021
@fassadlr fassadlr deleted the init-votingmgr branch February 23, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants