Merge interflux to master by zeptin · Pull Request #447 · stratisproject/StratisFullNode

zeptin · 2021-03-05T01:17:32Z

No description provided.

* Initial InterFlux version * Refactor

* Modify DI sequence

* Initial InterFlux version * Update NBitcoin.csproj (stratisproject#391) * Pass along height information for OP_FEDERATION (stratisproject#379) * Pass along height information for OP_FEDERATION * Add defaults * Add defaults * Filter Transaction History by Transaction Id (stratisproject#393) * Update WalletService.cs * Add Filter * Fix Test * Perform check for cold staking txs * Refactor * Modify DI sequence * Add mainnet check points (stratisproject#400) * Add MainNet check points * Fix Tests * Change gas limit upper bound to 250,000 (stratisproject#399) * Add UInt256, serialization methods and CLR updates (stratisproject#365) * Add UInt256 serialization methods * Refactor * Use UInt256 in InternalExecutor * Undo unrelated change * Update TestMessage * Revert type updates to InternalExecutor * Update Serializer and PersistentState * Update package versions * Update SC packages to version 1.4.0-alpha * Add serializers and enums * Add primitive serializer * Update StandardToken.cs * Revert change * Update integration tests * Use switch/case in Serialize/Deserialize * Update package versions and remove workaround * Ensure the right Stratis.SmartContracts.Standards is used by contracts * Changes based on feedback * Fix primitive deserialize * Update standards dll name * Fix legacy standards dll path * Don't upgrade standards package of node * Don't upgrade StandardToken of node * Don't upgrade standards package of node * Add Standards forwards compatibility * Add test case for futuristic contracts * Fix Token_Standards_Test * Update RPC_GetReceipt_Returns_Value test * Cleanup non-required changes * Validate standards assembly * Disable automatic downloads * Add LegacyStandardsDLLs * Update test * Bump package versions for Core and Networks * Bump observer version * Update package versions * Refactor * Revert gitignore * Revert unnecessary changes * Revert unnecessary changes * Update Stratis.SmartContracts.xxx to 2.0.0.0 * Update package version for Stratis.SmartContracts.Tests.Common * Add TestNet checkpoints (stratisproject#402) * Update StraxTest.cs * Add testnet checkpoints * Fix Tests * Update Nuget Scripts and Collateral/FederatedPeg versions * Bump Version (stratisproject#403) * Update some test projects PackageIds and versions * Update PushNuget.ps1 * Update MaxStandardSigOpsCost and CCTS Max Partials Txs (stratisproject#404) * Update Stratis.SmartContracts.CLR.Validation's allowed primitive types (stratisproject#405) * Update validator's primitives * Bump package version * Bump Stratis.SmartContracts.Core and Stratis.SmartContracts.CLR versions (stratisproject#406) * Update validator's primitives * Bump package version * Bump Stratis.SmartContracts.Core and Stratis.SmartContracts.CLR versions * Bump Stratis.Bicoin.Features.SmartContracts as well * Bump Stratis.SmartContracts.Networks * Update PushSCNuget.ps1 * Fix Finality Bug (stratisproject#407) * Fix Finalized Bug * Fix Build * Trigger CI * Fix Tests * Comments * Console Cleanup (stratisproject#408) * Suppress bench logs * Done * Update NodeStats.cs * Fix Test * Bump version prior to fixing NuGet dependencies for Stratis.SmartContracts.Tests.Common (stratisproject#409) * Rocks DB (stratisproject#401) * WIP * Fix DB connections * Update CirrusD * Add RocksDbNative * Update Stratis.CirrusD.csproj * Add Snappy * Fix BlockStoreQueue * Add switch to program.cs * Fix Logger * Cleanup Console Logs * Add RocksDbChainStore * Update BlockPuller.cs * Implement RocksDb KeyValueStore * Add dbtype switch to StraxD * NodeStats changes * KeyValue fix * Fix Build * Voting / Wallet Log * Update ConnectionManager.cs * Hide bench stats * Update VersionProvider.cs * Self Review * Fix Test * Update ConnectionManager.cs * Fix Locks in StakeDB * Create RocksDbProvenBlockHeaderRepository * Update RocksDbProvenBlockHeaderRepository.cs * Add network type to console * Fix Test * Update NodeStats.cs * Add datafolder to nodestats * Fix Merge * Revert * Revert launchsettings * Add ColdStaking to PushNuGet script (stratisproject#410) * Add ColdStaking to PushNuGet script * Bump Stratis.Bitcoin.IntegrationTests.Common to 1.0.7 * Bump Stratis.Core.Tests.Common to 1.0.7 * Update NEthereum and Stratis.Patricia * SLN changes * Clean up commits * Remove launchSettings change Co-authored-by: Francois de la Rouviere <fassadlr@gmail.com> Co-authored-by: quantumagi <someguy.fromafrica@gmail.com>

* Initial InterFlux version * Update NBitcoin.csproj (stratisproject#391) * Pass along height information for OP_FEDERATION (stratisproject#379) * Pass along height information for OP_FEDERATION * Add defaults * Add defaults * Filter Transaction History by Transaction Id (stratisproject#393) * Update WalletService.cs * Add Filter * Fix Test * Perform check for cold staking txs * Refactor * Modify DI sequence * Add mainnet check points (stratisproject#400) * Add MainNet check points * Fix Tests * Change gas limit upper bound to 250,000 (stratisproject#399) * Add UInt256, serialization methods and CLR updates (stratisproject#365) * Add UInt256 serialization methods * Refactor * Use UInt256 in InternalExecutor * Undo unrelated change * Update TestMessage * Revert type updates to InternalExecutor * Update Serializer and PersistentState * Update package versions * Update SC packages to version 1.4.0-alpha * Add serializers and enums * Add primitive serializer * Update StandardToken.cs * Revert change * Update integration tests * Use switch/case in Serialize/Deserialize * Update package versions and remove workaround * Ensure the right Stratis.SmartContracts.Standards is used by contracts * Changes based on feedback * Fix primitive deserialize * Update standards dll name * Fix legacy standards dll path * Don't upgrade standards package of node * Don't upgrade StandardToken of node * Don't upgrade standards package of node * Add Standards forwards compatibility * Add test case for futuristic contracts * Fix Token_Standards_Test * Update RPC_GetReceipt_Returns_Value test * Cleanup non-required changes * Validate standards assembly * Disable automatic downloads * Add LegacyStandardsDLLs * Update test * Bump package versions for Core and Networks * Bump observer version * Update package versions * Refactor * Revert gitignore * Revert unnecessary changes * Revert unnecessary changes * Update Stratis.SmartContracts.xxx to 2.0.0.0 * Update package version for Stratis.SmartContracts.Tests.Common * Add TestNet checkpoints (stratisproject#402) * Update StraxTest.cs * Add testnet checkpoints * Fix Tests * Update Nuget Scripts and Collateral/FederatedPeg versions * Bump Version (stratisproject#403) * Update some test projects PackageIds and versions * Update PushNuget.ps1 * Update MaxStandardSigOpsCost and CCTS Max Partials Txs (stratisproject#404) * Update Stratis.SmartContracts.CLR.Validation's allowed primitive types (stratisproject#405) * Update validator's primitives * Bump package version * Bump Stratis.SmartContracts.Core and Stratis.SmartContracts.CLR versions (stratisproject#406) * Update validator's primitives * Bump package version * Bump Stratis.SmartContracts.Core and Stratis.SmartContracts.CLR versions * Bump Stratis.Bicoin.Features.SmartContracts as well * Bump Stratis.SmartContracts.Networks * Update PushSCNuget.ps1 * Fix Finality Bug (stratisproject#407) * Fix Finalized Bug * Fix Build * Trigger CI * Fix Tests * Comments * Console Cleanup (stratisproject#408) * Suppress bench logs * Done * Update NodeStats.cs * Fix Test * Bump version prior to fixing NuGet dependencies for Stratis.SmartContracts.Tests.Common (stratisproject#409) * Rocks DB (stratisproject#401) * WIP * Fix DB connections * Update CirrusD * Add RocksDbNative * Update Stratis.CirrusD.csproj * Add Snappy * Fix BlockStoreQueue * Add switch to program.cs * Fix Logger * Cleanup Console Logs * Add RocksDbChainStore * Update BlockPuller.cs * Implement RocksDb KeyValueStore * Add dbtype switch to StraxD * NodeStats changes * KeyValue fix * Fix Build * Voting / Wallet Log * Update ConnectionManager.cs * Hide bench stats * Update VersionProvider.cs * Self Review * Fix Test * Update ConnectionManager.cs * Fix Locks in StakeDB * Create RocksDbProvenBlockHeaderRepository * Update RocksDbProvenBlockHeaderRepository.cs * Add network type to console * Fix Test * Update NodeStats.cs * Add datafolder to nodestats * Fix Merge * Revert * Revert launchsettings * Add ColdStaking to PushNuGet script (stratisproject#410) * Add ColdStaking to PushNuGet script * Bump Stratis.Bitcoin.IntegrationTests.Common to 1.0.7 * Bump Stratis.Core.Tests.Common to 1.0.7 * Update NEthereum and Stratis.Patricia * SLN changes * Clean up commits * Remove launchSettings change * Add references Co-authored-by: Francois de la Rouviere <fassadlr@gmail.com> Co-authored-by: quantumagi <someguy.fromafrica@gmail.com>

* Update LaunchSidechainMasternode.ps1 * Update LaunchSidechainMasternode.ps1 * Update LaunchSidechainMasternode.ps1

* Update NBitcoin.csproj (stratisproject#391) * Pass along height information for OP_FEDERATION (stratisproject#379) * Pass along height information for OP_FEDERATION * Add defaults * Add defaults * Filter Transaction History by Transaction Id (stratisproject#393) * Update WalletService.cs * Add Filter * Fix Test * Perform check for cold staking txs * Add mainnet check points (stratisproject#400) * Add MainNet check points * Fix Tests * Change gas limit upper bound to 250,000 (stratisproject#399) * Add UInt256, serialization methods and CLR updates (stratisproject#365) * Add UInt256 serialization methods * Refactor * Use UInt256 in InternalExecutor * Undo unrelated change * Update TestMessage * Revert type updates to InternalExecutor * Update Serializer and PersistentState * Update package versions * Update SC packages to version 1.4.0-alpha * Add serializers and enums * Add primitive serializer * Update StandardToken.cs * Revert change * Update integration tests * Use switch/case in Serialize/Deserialize * Update package versions and remove workaround * Ensure the right Stratis.SmartContracts.Standards is used by contracts * Changes based on feedback * Fix primitive deserialize * Update standards dll name * Fix legacy standards dll path * Don't upgrade standards package of node * Don't upgrade StandardToken of node * Don't upgrade standards package of node * Add Standards forwards compatibility * Add test case for futuristic contracts * Fix Token_Standards_Test * Update RPC_GetReceipt_Returns_Value test * Cleanup non-required changes * Validate standards assembly * Disable automatic downloads * Add LegacyStandardsDLLs * Update test * Bump package versions for Core and Networks * Bump observer version * Update package versions * Refactor * Revert gitignore * Revert unnecessary changes * Revert unnecessary changes * Update Stratis.SmartContracts.xxx to 2.0.0.0 * Update package version for Stratis.SmartContracts.Tests.Common * Add TestNet checkpoints (stratisproject#402) * Update StraxTest.cs * Add testnet checkpoints * Fix Tests * Update Nuget Scripts and Collateral/FederatedPeg versions * Bump Version (stratisproject#403) * Update some test projects PackageIds and versions * Update PushNuget.ps1 * Update MaxStandardSigOpsCost and CCTS Max Partials Txs (stratisproject#404) * Update Stratis.SmartContracts.CLR.Validation's allowed primitive types (stratisproject#405) * Update validator's primitives * Bump package version * Bump Stratis.SmartContracts.Core and Stratis.SmartContracts.CLR versions (stratisproject#406) * Update validator's primitives * Bump package version * Bump Stratis.SmartContracts.Core and Stratis.SmartContracts.CLR versions * Bump Stratis.Bicoin.Features.SmartContracts as well * Bump Stratis.SmartContracts.Networks * Update PushSCNuget.ps1 * Fix Finality Bug (stratisproject#407) * Fix Finalized Bug * Fix Build * Trigger CI * Fix Tests * Comments * Console Cleanup (stratisproject#408) * Suppress bench logs * Done * Update NodeStats.cs * Fix Test * Bump version prior to fixing NuGet dependencies for Stratis.SmartContracts.Tests.Common (stratisproject#409) * Rocks DB (stratisproject#401) * WIP * Fix DB connections * Update CirrusD * Add RocksDbNative * Update Stratis.CirrusD.csproj * Add Snappy * Fix BlockStoreQueue * Add switch to program.cs * Fix Logger * Cleanup Console Logs * Add RocksDbChainStore * Update BlockPuller.cs * Implement RocksDb KeyValueStore * Add dbtype switch to StraxD * NodeStats changes * KeyValue fix * Fix Build * Voting / Wallet Log * Update ConnectionManager.cs * Hide bench stats * Update VersionProvider.cs * Self Review * Fix Test * Update ConnectionManager.cs * Fix Locks in StakeDB * Create RocksDbProvenBlockHeaderRepository * Update RocksDbProvenBlockHeaderRepository.cs * Add network type to console * Fix Test * Update NodeStats.cs * Add datafolder to nodestats * Fix Merge * Revert * Revert launchsettings * Add ColdStaking to PushNuGet script (stratisproject#410) * Add ColdStaking to PushNuGet script * Bump Stratis.Bitcoin.IntegrationTests.Common to 1.0.7 * Bump Stratis.Core.Tests.Common to 1.0.7 * Update to Stratis.RocksDb (stratisproject#415) * Prevent changing published packages w/o bumping local version (stratisproject#411) * Prevent changing package code of published version - must bump version * Update comments * Small refactor * Ensure Release folder exists * Check version changes related to project references * Bump versions * Refactor * Refactor * Fix wallet feature vesion * Update RocksDb dylibs (stratisproject#417) * Update to Stratis.RocksDb * Update to version 0.0.9.1 * Update RocksDb Nugets * Update Rocksdb (stratisproject#418) * Revert "Dont fetch/process deposits until the CCTS has cleared its suspended transfers (stratisproject#367)" This reverts commit 334b4f0. * Update Nuget * Update CirrusMain.cs (stratisproject#422) * Consolidate outstanding console changes for the MS/Miner (stratisproject#423) * update RocksDb Nuget (stratisproject#424) * Update Stratis.Bitcoin Assembly info to version 1.0.7.2 * Fix Seeder (stratisproject#425) * Fix AddressIndexer Console (stratisproject#426) * Update ConnectionManager.cs (stratisproject#427) * Fix merge conflicts Co-authored-by: Francois de la Rouviere <fassadlr@gmail.com> Co-authored-by: quantumagi <someguy.fromafrica@gmail.com>

…ject#432)

src/Stratis.Bitcoin.Features.Interop/EthereumClient/ContractSource/MultisigWallet.sol

noescape00 · 2021-03-05T13:30:28Z

src/Stratis.Bitcoin.Features.Interop/EthereumClient/EthereumClientBase.cs

+            this.filterId = this.transferEventHandler.CreateFilterAsync(this.filterAllTransferEventsForContract).GetAwaiter().GetResult();
+        }
+
+        public List<EventLog<TransferEventDTO>> GetTransferEventsForWrappedStrax()


this method and the one that calls it can be made async to avoid doing .GetAwaiter().GetResult(); in the code

@noescape00 I suspect this is because of NEthereum's interface contract not being async or not returning Task? @zeptin can you confirm?

noescape00 · 2021-03-05T13:31:18Z

src/Stratis.Bitcoin.Features.Interop/EthereumClient/EthereumClientBase.cs

+
+namespace Stratis.Bitcoin.Features.Interop.EthereumClient
+{
+    public class EthereumClientBase : IEthereumClientBase


Please add xmldoc for methods in the class (and also for other methods in this PR that are not documented)

noescape00 · 2021-03-05T13:36:29Z

src/Stratis.Bitcoin.Features.Interop/EthereumClient/EthereumClientBase.cs

+            return result;
+        }
+
+        public Dictionary<string, string> InvokeContract(InteropRequest request)


some of the methods in this class are not used, some return empty values. Those probably should be implemented or removed

noescape00 · 2021-03-05T13:38:36Z

src/Stratis.Bitcoin.Features.Interop/EthereumClient/MultisigWallet.cs

+
+    public class MultisigWalletDeployment : ContractDeploymentMessage
+    {
+        public static string BYTECODE =


maybe use resources instead of hardcoding it here

noescape00 · 2021-03-05T13:45:30Z

src/Stratis.Bitcoin.Features.Interop/IInteropTransactionManager.cs

+
+namespace Stratis.Bitcoin.Features.Interop
+{
+    public interface IInteropTransactionManager


please add xml doc here and everywhere where it's absent

src/Stratis.Bitcoin.Features.Interop/InteropBehavior.cs

noescape00 · 2021-03-05T13:52:00Z

src/Stratis.Bitcoin.Features.Interop/InteropFeature.cs

+                    .FeatureServices(services => services
+                    .AddSingleton<InteropSettings>()
+                    .AddSingleton<IEthereumClientBase, EthereumClientBase>()
+                    //.AddSingleton<IInteropRequestRepository, InteropRequestRepository>()


uncomment or remove

noescape00 · 2021-03-05T13:52:35Z

src/Stratis.Bitcoin.Features.Interop/InteropPoller.cs

+        private const string LastScannedHeightKey = "InteropLastScannedHeight";
+        private const int InteropBatchSize = 100;
+
+        private const string ContractAddressKeyPrefix = "CN";


those constants are not used

noescape00 · 2021-03-05T13:54:21Z

src/Stratis.Bitcoin.Features.Interop/InteropPoller.cs

+
+namespace Stratis.Bitcoin.Features.Interop
+{
+    public class InteropPoller : IDisposable


it's an important class, please add documentation

src/Stratis.Bitcoin.Features.Interop/Stratis.Bitcoin.Features.Interop.csproj

src/Stratis.Bitcoin.Features.MemoryPool/Rules/CheckSigOpsMempoolRule.cs

src/Stratis.CirrusPegD/Properties/launchSettings.json

fassadlr · 2021-03-05T16:03:48Z

src/Stratis.Features.FederatedPeg/Conversion/ConversionRequest.cs

+        Processed
+    }
+
+    public class ConversionRequest : IBitcoinSerializable


It would be good to at least add a high level summary on what these new classes do and/or are used for?

noescape00 · 2021-03-05T16:01:04Z

src/Stratis.Bitcoin.Features.Interop/InteropPoller.cs

+
+                    try
+                    {
+                        this.CheckEthereumNode();


probably better to do it once on initialization

src/Stratis.Bitcoin.Features.Interop/EthereumClient/MultisigWallet.cs

src/Stratis.Bitcoin.Features.Interop/EthereumClient/IEthereumClientBase.cs

fassadlr · 2021-03-08T07:09:06Z

src/Stratis.Bitcoin.Features.Interop/InteropBehavior.cs

+            Guard.NotNull(interopTransactionManager, nameof(interopTransactionManager));
+            Guard.NotNull(ethereumClientBase, nameof(ethereumClientBase));
+
+            this.logger = loggerFactory.CreateLogger(this.GetType().FullName);


It might be cool if we can implement new code with NLog's LogManager.GetCurrentClassLogger(). Not essential here, perhaps in another PR.

fassadlr · 2021-03-08T07:13:53Z

src/Stratis.Features.FederatedPeg/Conversion/IConversionRequestRepository.cs

+
+namespace Stratis.Bitcoin.Features.FederatedPeg
+{
+    public interface IConversionRequestRepository


Perhaps comment these methods?

fassadlr · 2021-03-08T07:15:22Z

src/Stratis.Features.FederatedPeg.Tests/RestClientsTests/RestApiClientBaseTests.cs

            this.logger = Substitute.For<ILogger>();
            this.loggerFactory.CreateLogger(null).ReturnsForAnyArgs(this.logger);
-            this.httpClientFactory = new HttpClientFactory();
+            this.httpClientFactory = new Bitcoin.Controllers.HttpClientFactory();


Hmmm why this namespace add?

fassadlr · 2021-03-08T07:18:05Z

src/Stratis.Bitcoin.Features.Interop/Models/EthereumRequestModel.cs

+
+namespace Stratis.Bitcoin.Features.Interop.Models
+{
+    public class EthereumRequestModel


Not sure if JsonProperty attributes should be added here?

fassadlr · 2021-03-08T07:19:33Z

src/Stratis.Bitcoin.Features.Interop/InteropTransactionManager.cs

+            }
+        }
+
+        public void RemoveTransaction(string requestId)


How does transaction's get removed?

fassadlr · 2021-03-08T07:22:37Z

src/Stratis.Bitcoin.Features.Interop/InteropFeature.cs

+
+        public override Task InitializeAsync()
+        {
+            this.interopPoller?.Initialize();


How do we guarantee that this is called after the federation feature has initialized? As we rely on things like "IsFederationMember" etc.

Hmm, the interoperability feature should initialize well after the federation manager, is it necessary to explicitly check that it has completed before using IsFederationMember?

I think it's ok. We just need to ensure that initialization sequence is correct

noescape00 · 2021-03-08T11:40:57Z

src/Stratis.Bitcoin.Features.Interop/InteropPoller.cs

+                    }
+                    catch (Exception e)
+                    {
+                        this.logger.LogWarning("Exception raised when checking interop requests. {0}", 0);


exception is not logged

noescape00 · 2021-03-08T11:41:42Z

src/Stratis.Bitcoin.Features.Interop/InteropPoller.cs

+            return requests;
+        }
+
+        private void ProcessEthereumRequests()


a lot of unused code above and blow this point

noescape00

also please implement TODOs

noescape00 · 2021-03-11T08:15:12Z

src/Stratis.Bitcoin.Features.Interop/InteropBehavior.cs

+            this.ethereumClientBase = ethereumClientBase;
+        }
+
+        [NoTrace]


fody was removed from codebase according to @fassadlr , so this tag is not needed

noescape00 · 2021-03-11T08:19:34Z

src/Stratis.Bitcoin.Features.Interop/InteropPoller.cs

+
+                    return;
+                }
+                else


else and {} are not needed

noescape00 · 2021-03-11T08:20:25Z

src/Stratis.Bitcoin.Features.Interop/InteropRequest.cs

+{
+    public enum InteropRequestType
+    {
+        // Stratis (Cirrus) network invoking Ethereum contract.


convert to xmldoc

noescape00 · 2021-03-11T08:21:10Z

src/Stratis.Bitcoin.Features.Interop/InteropRequest.cs

+        /// <summary>
+        /// For either type of invocation, this is the name of the method that is to be invoked.
+        /// </summary>
+        public string MethodName { get { return this.methodName; } set { this.methodName = value; } }


this is not used anywhere

noescape00 · 2021-03-11T08:23:41Z

src/Stratis.Bitcoin.Features.Interop/InteropSettings.cs

+
+        public bool Enabled { get; set; }
+
+        public string InteropContractCirrusAddress { get; set; }


please comment all properties

noescape00 · 2021-03-24T13:05:25Z

Updated version is here: #481

fassadlr and others added 20 commits January 20, 2021 13:56

Update NBitcoin.csproj (stratisproject#391)

6d33c0c

Interflux (stratisproject#397)

eb28341

* Initial InterFlux version * Refactor

Modify DI sequence (stratisproject#398)

bd900d0

* Modify DI sequence

Conditional invocation (stratisproject#419)

f86cc65

Update LaunchSidechainMasternode.ps1 (stratisproject#420)

88af058

* Update LaunchSidechainMasternode.ps1 * Update LaunchSidechainMasternode.ps1 * Update LaunchSidechainMasternode.ps1

Update LaunchSidechainMasternode.ps1

c4d5778

Update LaunchSidechainMasternode.ps1

9556513

Update LaunchSidechainMasternode.ps1

c4175b4

Update LaunchSidechainMasternode.ps1

4bdb926

Update LaunchSidechainMasternode.ps1

f687dc1

Move interflux namespace (stratisproject#428)

3f8c476

Fix null reference (stratisproject#429)

dbb5b55

Add signature to coordination payload and improve logging (stratispro…

737b7c3

…ject#432)

Fix constructor (stratisproject#433)

fad2c07

Configurable gas limit and price (stratisproject#434)

62f24f1

Recreate event filter on RPC exception

5ff9ab7

Merge master

446321a

noescape00 reviewed Mar 5, 2021

View reviewed changes

fassadlr reviewed Mar 5, 2021

View reviewed changes

src/Stratis.Bitcoin.Features.Interop/Stratis.Bitcoin.Features.Interop.csproj Outdated Show resolved Hide resolved

fassadlr reviewed Mar 5, 2021

View reviewed changes

src/Stratis.Bitcoin.Features.MemoryPool/Rules/CheckSigOpsMempoolRule.cs Outdated Show resolved Hide resolved

fassadlr reviewed Mar 5, 2021

View reviewed changes

src/Stratis.CirrusPegD/Properties/launchSettings.json Outdated Show resolved Hide resolved

fassadlr reviewed Mar 5, 2021

View reviewed changes

Clean up

4caff9a

noescape00 reviewed Mar 5, 2021

View reviewed changes

Fixes & updated deposit confirmation intervals

bfc4e32

fassadlr reviewed Mar 8, 2021

View reviewed changes

src/Stratis.Bitcoin.Features.Interop/EthereumClient/IEthereumClientBase.cs Show resolved Hide resolved

fassadlr reviewed Mar 8, 2021

View reviewed changes

Asyncify

bb8f5a8

noescape00 reviewed Mar 8, 2021

View reviewed changes

zeptin added 2 commits March 8, 2021 14:32

Remove unused

ee9d7ee

Add minimum threshold

cc52554

noescape00 reviewed Mar 11, 2021

View reviewed changes

noescape00 closed this Mar 24, 2021


		public bool Enabled { get; set; }

		public string InteropContractCirrusAddress { get; set; }

Conversation

zeptin commented Mar 5, 2021

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fassadlr Mar 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fassadlr Mar 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

noescape00 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

noescape00 commented Mar 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fassadlr Mar 8, 2021 •

edited

Loading

fassadlr Mar 8, 2021 •

edited

Loading