Skip to content

Fix FullNode Dispose#460

Merged
quantumagi merged 1 commit intostratisproject:masterfrom
quantumagi:fixfullnodedispose
Mar 12, 2021
Merged

Fix FullNode Dispose#460
quantumagi merged 1 commit intostratisproject:masterfrom
quantumagi:fixfullnodedispose

Conversation

@quantumagi
Copy link
Contributor

No description provided.

@quantumagi quantumagi requested a review from fassadlr March 12, 2021 04:43
Copy link
Contributor

@fassadlr fassadlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quantumagi where and how did you observe the nulls?

@quantumagi
Copy link
Contributor Author

@fassadlr , I had a scenario during system contract development where an error occurred before the node had been started. At the time I could not observe the actual error due to these issues in the FullNode's Dispose method.

@quantumagi quantumagi merged commit 2e65aa8 into stratisproject:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants