Make SC wallet feature derive from any base wallet#471
Merged
quantumagi merged 3 commits intostratisproject:masterfrom Mar 18, 2021
Merged
Make SC wallet feature derive from any base wallet#471quantumagi merged 3 commits intostratisproject:masterfrom
quantumagi merged 3 commits intostratisproject:masterfrom
Conversation
fassadlr
reviewed
Mar 18, 2021
| IWalletManager walletManager, | ||
| IWalletSyncManager walletSyncManager, | ||
| INodeStats nodeStats) | ||
| public SmartContractWalletFeature(ILoggerFactory loggerFactory) |
Contributor
There was a problem hiding this comment.
You might as well remove the loggerfactory here as well and use NLog's LogManager.GetCurrentClassLogger below ;)
fassadlr
reviewed
Mar 18, 2021
| { | ||
| LoggingConfiguration.RegisterFeatureNamespace<WalletFeature>("smart contract wallet"); | ||
|
|
||
| if (addVanillaWallet) |
Contributor
There was a problem hiding this comment.
Wont this then always be true? Why would we call this with false?
Contributor
Author
There was a problem hiding this comment.
In StraxD we would have:
.UseColdStakingWallet()
.UseSmartContractWallet(false)
fassadlr
reviewed
Mar 18, 2021
Contributor
fassadlr
left a comment
fassadlr
left a comment
There was a problem hiding this comment.
Just remove that loggerfactory and we can approve and merge.
fassadlr
approved these changes
Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We must be able to use the SC wallet feature with the Strax daemon which currently implements the cold staking wallet.
This is a backwards compatible change required by system contracts.