Make AllowedCodeHashLogic rule reusable and pass block height#474
Merged
quantumagi merged 2 commits intostratisproject:masterfrom Mar 18, 2021
Merged
Make AllowedCodeHashLogic rule reusable and pass block height#474quantumagi merged 2 commits intostratisproject:masterfrom
quantumagi merged 2 commits intostratisproject:masterfrom
Conversation
fassadlr
approved these changes
Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contract permissions can vary with block height and as such we need to pass the block height to this rule. The PoA whitelist checker should probably be using this information too but that is out-of-scope for this PR.
This is a backwards compatible change required by system contracts.