[SC] Add ToStringJsonConverter for UInt128/UInt256#483
Merged
quantumagi merged 8 commits intostratisproject:masterfrom Mar 27, 2021
Merged
[SC] Add ToStringJsonConverter for UInt128/UInt256#483quantumagi merged 8 commits intostratisproject:masterfrom
quantumagi merged 8 commits intostratisproject:masterfrom
Conversation
mrtpain
approved these changes
Mar 26, 2021
mrtpain
left a comment
mrtpain
left a comment
There was a problem hiding this comment.
Looks good to me and working well 👍 nice work, thanks again! 😎
fassadlr
approved these changes
Mar 26, 2021
YakupIpek
reviewed
Mar 26, 2021
YakupIpek
reviewed
Mar 26, 2021
...tis.Bitcoin.Features.SmartContracts/ReflectionExecutor/ContractParametersContractResolver.cs
Show resolved
Hide resolved
YakupIpek
reviewed
Mar 26, 2021
src/Stratis.Bitcoin.Features.SmartContracts/ReflectionExecutor/ToStringJsonConverter.cs
Outdated
Show resolved
Hide resolved
YakupIpek
reviewed
Mar 26, 2021
src/Stratis.Bitcoin.Features.SmartContracts/ReflectionExecutor/ToStringJsonConverter.cs
Outdated
Show resolved
Hide resolved
YakupIpek
suggested changes
Mar 26, 2021
Contributor
YakupIpek
left a comment
YakupIpek
left a comment
There was a problem hiding this comment.
Can you also add new types to Deserialize_Basic_Log_Success method.
YakupIpek
reviewed
Mar 26, 2021
src/Stratis.Bitcoin.Features.SmartContracts/ReflectionExecutor/ToStringJsonConverter.cs
Outdated
Show resolved
Hide resolved
quantumagi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.