[MultiSig] CCTS should only sync once Fed wallet is synced#508
Merged
fassadlr merged 3 commits intostratisproject:masterfrom Apr 12, 2021
Merged
[MultiSig] CCTS should only sync once Fed wallet is synced#508fassadlr merged 3 commits intostratisproject:masterfrom
fassadlr merged 3 commits intostratisproject:masterfrom
Conversation
quantumagi
reviewed
Apr 12, 2021
src/Stratis.Features.FederatedPeg/TargetChain/MaturedBlocksSyncManager.cs
Show resolved
Hide resolved
quantumagi
reviewed
Apr 12, 2021
| } | ||
|
|
||
| // Then ensure that the federation wallet is synced with the chain. | ||
| if (this.federationWalletManager.WalletTipHeight < this.chainIndexer.Tip.Height - FederationWalletTipSyncBuffer) |
Contributor
There was a problem hiding this comment.
Could an additional check be added to not run the CCTS sync when the wallet needs to be consolidated?
quantumagi
approved these changes
Apr 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.clickup.com/t/nq2m0u
I tested this with a CirrusTest resync of the CCTS and federation wallet.