Skip to content

Fix SignalR connectioninfo naming consistency #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fassadlr merged 2 commits into from
Apr 15, 2021
Merged

Fix SignalR connectioninfo naming consistency #513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8a1446
Fix SignalRPort for straxUI
TjadenFroyda Apr 14, 2021
b9b64c8
Update SignalRSettings.cs
TjadenFroyda Apr 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Stratis.Bitcoin.Features.SignalR/Controllers/SignalRController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public SignalRController(SignalRSettings signalRSettings)
/// <summary>
/// Returns SignalR Connection Info.
/// </summary>
/// <returns>Returns SignalR Connection Info as Json {SignalRUri,SignalPort}</returns>
/// <returns>Returns SignalR Connection Info as Json {SignalRUri,SignalRPort}</returns>
/// <response code="200">Returns connection info</response>
[Route("getConnectionInfo")]
[HttpGet]
Expand All @@ -32,8 +32,8 @@ public IActionResult GetConnectionInfo()
return this.Json(new
{
this.signalRSettings.SignalRUri,
this.signalRSettings.SignalPort
this.signalRSettings.SignalRPort
});
}
}
}
}
6 changes: 3 additions & 3 deletions src/Stratis.Bitcoin.Features.SignalR/SignalRSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public class SignalRSettings
public Uri SignalRUri { get; set; }

/// <summary>Port of node's Signal interface.</summary>
public int SignalPort { get; set; }
public int SignalRPort { get; set; }

public SignalRSettings(NodeSettings nodeSettings)
{
Expand All @@ -42,12 +42,12 @@ public SignalRSettings(NodeSettings nodeSettings)
if (uri.IsDefaultPort)
{
this.SignalRUri = new Uri($"{host}:{port}");
this.SignalPort = port;
this.SignalRPort = port;
}
else
{
this.SignalRUri = uri;
this.SignalPort = uri.Port;
this.SignalRPort = uri.Port;
}
}

Expand Down