Fix locks in RocksDB repositories#517
Merged
fassadlr merged 4 commits intostratisproject:masterfrom Apr 23, 2021
Merged
Conversation
Contributor
Author
|
I have tested a full sync of Strax Mainnet |
Contributor
Author
|
I have done:
|
zeptin
pushed a commit
to zeptin/StratisFullNode
that referenced
this pull request
Jun 15, 2021
* Fix locks in RocksDB repos * Update RocksDbKeyValueRepository.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rocks DB implementation of the repos was done by opening and closing the db connection as and when access were required which seems to slow down the sync massively. It is now in line with how the level db repos wortk by opening the connection on start up.