[MultiSig] Exclude dust from input selection in the MS wallet.#520
Merged
fassadlr merged 4 commits intostratisproject:masterfrom Apr 16, 2021
Merged
[MultiSig] Exclude dust from input selection in the MS wallet.#520fassadlr merged 4 commits intostratisproject:masterfrom
fassadlr merged 4 commits intostratisproject:masterfrom
Conversation
fassadlr
changed the title
quantumagi
approved these changes
Apr 16, 2021
Contributor
There was a problem hiding this comment.
LGTM
For the next PR: IsSpendable is not use in that many places. Should be easy to verify the approach and move the dust check there. That way we don't accumulate more and more dust that will be returned by the index and have to then be "scanned"
fassadlr
added a commit
that referenced
this pull request
Apr 16, 2021
* Exclude dust from ValidateTransaction * Standardize dust filtering * Make dust threshold constant * Fix Tests
fassadlr
added a commit
to zeptin/StratisFullNode
that referenced
this pull request
May 27, 2021
…isproject#520) * Exclude dust from ValidateTransaction * Standardize dust filtering * Make dust threshold constant * Fix Tests
zeptin
pushed a commit
to zeptin/StratisFullNode
that referenced
this pull request
Jun 15, 2021
…isproject#520) * Exclude dust from ValidateTransaction * Standardize dust filtering * Make dust threshold constant * Fix Tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we are filtering dust UTXOs from the withdrawal builder we need to also filter them when validating the transaction.
Not doing so fails the logic which checks if earliest unspent UTXO was used.