[SC] Additional storage tests#524
Merged
rowandh merged 2 commits intostratisproject:masterfrom Apr 20, 2021
Merged
Conversation
YakupIpek
reviewed
Apr 19, 2021
| repository.Commit(); | ||
|
|
||
| // We have pushed null to the kv store. Should come back as null | ||
| StateRepositoryRoot repository2 = new StateRepositoryRoot(stateDB, repository.Root); |
Contributor
There was a problem hiding this comment.
You use var and actual type together as style. Which one we should follow ?
YakupIpek
approved these changes
Apr 19, 2021
quantumagi
approved these changes
Apr 20, 2021
zeptin
pushed a commit
to zeptin/StratisFullNode
that referenced
this pull request
Jun 15, 2021
* Add repository null tests * Add test demonstrating null and empty behaviour
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests to demonstrate the behaviour when storing
nullandbyte[0]in the repository