SmartContract methods for UnityAPI#597
Merged
noescape00 merged 4 commits intostratisproject:masterfrom Jun 30, 2021
Merged
Conversation
fassadlr
reviewed
Jun 30, 2021
| receiptResponse = new ReceiptResponse(receipt, logResponses, this.network); | ||
| } | ||
|
|
||
| return receiptResponse; |
Contributor
There was a problem hiding this comment.
Looks good Ivan, I would just add this controller method and the one below in a try catch, like we do in all the other controller methods. Just so that there is some consistency? WDYT?
Example:
Contributor
Author
There was a problem hiding this comment.
There is no need for try catch since if there is an exception it will be seen in node's logs.
Also we can't use same error handling since controller's methods return explicit types, not json like our other controllers.
fassadlr
approved these changes
Jun 30, 2021
Contributor
fassadlr
left a comment
fassadlr
left a comment
There was a problem hiding this comment.
Just add the try catch as in the comment :)
fassadlr
pushed a commit
that referenced
this pull request
Aug 9, 2021
* added sc related api methods * fix * explicit return types * codestyle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.