Prevent duplicate polls in polling DB#659
Merged
fassadlr merged 7 commits intostratisproject:release/1.1.0.0from Aug 19, 2021
Merged
Prevent duplicate polls in polling DB#659fassadlr merged 7 commits intostratisproject:release/1.1.0.0from
fassadlr merged 7 commits intostratisproject:release/1.1.0.0from
Conversation
Merged
fassadlr
reviewed
Aug 18, 2021
|
|
||
| public void Add(Poll poll) | ||
| { | ||
| Guard.Assert(!this.polls.Contains(poll)); |
Contributor
There was a problem hiding this comment.
Im wondering whether we should perhaps LogWarning the poll details and rather just return? So that we know about a poll that was attempting to be re-added?
fassadlr
reviewed
Aug 18, 2021
fassadlr
approved these changes
Aug 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errors relating to duplicate collateral addresses can be traced back to the existence of duplicate polls in the polling db which then leads to duplication of federation member data.
Federation can't contain members with duplicated collateral addresses.This PR aims to prevent the possibility of duplicate polls.
Duplicate polling data could affect the federation make-up and lead to errors that indirectly relate to the federation.
See https://app.clickup.com/t/75j74e.