CirrusMain checkpoint 2_827_550#680
Merged
quantumagi merged 1 commit intostratisproject:masterfrom Aug 26, 2021
Merged
Conversation
fassadlr
approved these changes
Aug 26, 2021
zeptin
approved these changes
Aug 26, 2021
fassadlr
pushed a commit
that referenced
this pull request
Aug 26, 2021
fassadlr
pushed a commit
that referenced
this pull request
Aug 26, 2021
fassadlr
added a commit
that referenced
this pull request
Aug 31, 2021
* Better collateral address checking (#670) * Add collateral address check to GetModifiedFederation (#671) * Remove logging from federation build logic * Update all versions to 1.0.9.3 * Add null check in IdleMemberKicker (#673) * Add null check in IdleMemberKicker * Update IdleFederationMembersKicker.cs * Bump version * Add null check in IdleMemberKicker (#673) (#674) * Add null check in IdleMemberKicker * Update IdleFederationMembersKicker.cs * Update all project versions to 1.0.9.4 * Bump SC versions * Validate ChainStore tip on load (#600) * Validate ChainStore tip on load * Change comment * Update tests * Dispose IChainStore * Bump version * CirrusMain checkpoint 2_827_550 (#680) * Bump version to 1.0.9.5 * Merge Disable signature rule in IBD #579 from release/1.1.0.0 Co-authored-by: quantumagi <someguy.fromafrica@gmail.com>
fassadlr
added a commit
that referenced
this pull request
Aug 31, 2021
* Better collateral address checking (#670) * Add collateral address check to GetModifiedFederation (#671) * Remove logging from federation build logic * Update all versions to 1.0.9.3 * Add null check in IdleMemberKicker (#673) * Add null check in IdleMemberKicker * Update IdleFederationMembersKicker.cs * Bump version * Add null check in IdleMemberKicker (#673) (#674) * Add null check in IdleMemberKicker * Update IdleFederationMembersKicker.cs * Update all project versions to 1.0.9.4 * Bump SC versions * Validate ChainStore tip on load (#600) * Validate ChainStore tip on load * Change comment * Update tests * Dispose IChainStore * Bump version * CirrusMain checkpoint 2_827_550 (#680) * Bump version to 1.0.9.5 * Merge Disable signature rule in IBD #579 from release/1.1.0.0 * UI SignalR improvements / Move UI notification outside of loop blocks (#686) Co-authored-by: quantumagi <someguy.fromafrica@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://app.clickup.com/t/1dyq4z2.
It appears that the
CirrusMainchain contains a few blocks that were mined by older/minority versions of the node that would not be mineable with the latest code version. The situation probably came about due to many of the newer nodes not being able to mine at the time.The purpose of this PR is to exclude the blocks which led to "block timestamp too early" errors from the
PoAHeaderSignatureRulerule by virtue of this existing code: