Skip to content

CirrusMain checkpoint 2_827_550#680

Merged
quantumagi merged 1 commit intostratisproject:masterfrom
quantumagi:ckp_2_827_550
Aug 26, 2021
Merged

CirrusMain checkpoint 2_827_550#680
quantumagi merged 1 commit intostratisproject:masterfrom
quantumagi:ckp_2_827_550

Conversation

@quantumagi
Copy link
Contributor

@quantumagi quantumagi commented Aug 25, 2021

See https://app.clickup.com/t/1dyq4z2.

It appears that the CirrusMain chain contains a few blocks that were mined by older/minority versions of the node that would not be mineable with the latest code version. The situation probably came about due to many of the newer nodes not being able to mine at the time.

The purpose of this PR is to exclude the blocks which led to "block timestamp too early" errors from the PoAHeaderSignatureRule rule by virtue of this existing code:

        public override async Task RunAsync(RuleContext context)
        {
            // Only start validating at the last checkpoint block.
            if (context.ValidationContext.ChainedHeaderToValidate.Height < (this.lastCheckPoint?.Height ?? 0))
                return;

            ChainedHeader chainedHeader = context.ValidationContext.ChainedHeaderToValidate;

@quantumagi quantumagi requested a review from fassadlr August 25, 2021 12:07
@quantumagi quantumagi merged commit 9e86c91 into stratisproject:master Aug 26, 2021
fassadlr pushed a commit that referenced this pull request Aug 26, 2021
fassadlr pushed a commit that referenced this pull request Aug 26, 2021
fassadlr added a commit that referenced this pull request Aug 31, 2021
* Better collateral address checking (#670)

* Add collateral address check to GetModifiedFederation (#671)

* Remove logging from federation build logic

* Update all versions to 1.0.9.3

* Add null check in IdleMemberKicker (#673)

* Add null check in IdleMemberKicker

* Update IdleFederationMembersKicker.cs

* Bump version

* Add null check in IdleMemberKicker (#673) (#674)

* Add null check in IdleMemberKicker

* Update IdleFederationMembersKicker.cs

* Update all project versions to 1.0.9.4

* Bump SC versions

* Validate ChainStore tip on load (#600)

* Validate ChainStore tip on load

* Change comment

* Update tests

* Dispose IChainStore

* Bump version

* CirrusMain checkpoint 2_827_550 (#680)

* Bump version to 1.0.9.5

* Merge Disable signature rule in IBD #579 from release/1.1.0.0

Co-authored-by: quantumagi <someguy.fromafrica@gmail.com>
fassadlr added a commit that referenced this pull request Aug 31, 2021
* Better collateral address checking (#670)

* Add collateral address check to GetModifiedFederation (#671)

* Remove logging from federation build logic

* Update all versions to 1.0.9.3

* Add null check in IdleMemberKicker (#673)

* Add null check in IdleMemberKicker

* Update IdleFederationMembersKicker.cs

* Bump version

* Add null check in IdleMemberKicker (#673) (#674)

* Add null check in IdleMemberKicker

* Update IdleFederationMembersKicker.cs

* Update all project versions to 1.0.9.4

* Bump SC versions

* Validate ChainStore tip on load (#600)

* Validate ChainStore tip on load

* Change comment

* Update tests

* Dispose IChainStore

* Bump version

* CirrusMain checkpoint 2_827_550 (#680)

* Bump version to 1.0.9.5

* Merge Disable signature rule in IBD #579 from release/1.1.0.0

* UI SignalR improvements / Move UI notification outside of loop blocks (#686)

Co-authored-by: quantumagi <someguy.fromafrica@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants