[RPC] Endpoints returning null appear to be handled incorrectly#688
Merged
zeptin merged 1 commit intorelease/1.1.0.0from Sep 1, 2021
Merged
[RPC] Endpoints returning null appear to be handled incorrectly#688zeptin merged 1 commit intorelease/1.1.0.0from
zeptin merged 1 commit intorelease/1.1.0.0from
Conversation
fassadlr
approved these changes
Sep 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While adding some SFN nodes to the RPC tests run against bitcoind, it was found that the
gettxoutRPC for a nonexistent UTXO was returning different results. I.e. the RPCClient was not receiving anullresult element in the JSON RPCResponse to convert back to an actual null; which should then be returned at the conclusion of theGetTxOutclient method.The fix in the middleware is experimental, it corrects the gettxout case, but there may be other scenarios it does not cater for.