Allow legacy duplicate polls#705
Closed
quantumagi wants to merge 2 commits intostratisproject:release/1.1.0.0from
Closed
Allow legacy duplicate polls#705quantumagi wants to merge 2 commits intostratisproject:release/1.1.0.0from
quantumagi wants to merge 2 commits intostratisproject:release/1.1.0.0from
Conversation
Contributor
Author
|
This issue is probably due to the error fixed in #706 and as such this PR can be closed for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://app.clickup.com/t/9vde7f.
At some points during a resync involving legacy blocks a situation can arise where more than one pending poll is voting on the same voting data. Although we are specifically trying to avoid that going forwards we still have to support the legacy blocks. This PR introduces the necessary code to do that.