[RPC] Make listunspent return watchOnly account transactions#759
Merged
zeptin merged 4 commits intostratisproject:release/1.2.0.0from Nov 16, 2021
Merged
Conversation
Contributor
|
Will have a look on Monday. |
quantumagi
reviewed
Nov 8, 2021
quantumagi
reviewed
Nov 8, 2021
src/Stratis.Features.SQLiteWalletRepository/SQLiteWalletRepository.cs
Outdated
Show resolved
Hide resolved
quantumagi
reviewed
Nov 8, 2021
src/Stratis.Features.SQLiteWalletRepository/SQLiteWalletRepository.cs
Outdated
Show resolved
Hide resolved
Contributor
|
Looks good. Just a few comments. |
fassadlr
approved these changes
Nov 16, 2021
rowandh
pushed a commit
that referenced
this pull request
Dec 2, 2021
* Make listunspent return watchOnly account transactions * Cleanup * Fixes per review * Fix RPC exception when adding duplicate watch-only addresses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Watch-only transactions are stored in an account without an extPubKey (as all the transactions generally have pubkeys that are not derived from any keypath within the wallet). This requires some workarounds at the wallet database level.